Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial accessors autocorrect #967

Merged
merged 1 commit into from
Apr 7, 2014
Merged

Trivial accessors autocorrect #967

merged 1 commit into from
Apr 7, 2014

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Apr 6, 2014

@bbatsov this builds on the others

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 6, 2014

LGMT. @jonas054 @yujinakayama Any remarks from you?

@@ -4,6 +4,13 @@

## 0.20.1 (05/04/2014)

### New features
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should move the new features section under the master section as 0.20.1 was released yesterday.

@tamird
Copy link
Contributor Author

tamird commented Apr 7, 2014

ping

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 7, 2014

Guess @jonas054 and @yujinakayama don't have any remarks. Rebase the PR on top of the current master.

@tamird
Copy link
Contributor Author

tamird commented Apr 7, 2014

It's already rebased, no?

bbatsov added a commit that referenced this pull request Apr 7, 2014
@bbatsov bbatsov merged commit df98ec7 into rubocop:master Apr 7, 2014
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 7, 2014

My bad. I was looking at another PR as well and confused them both.

@tamird tamird deleted the trivial-accessors-autocorret branch April 7, 2014 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants