Let the Debugger cop also check for byebug calls #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| inspect_source(cop, src) | ||
| expect(cop.offenses).to be_empty | ||
| end | ||
|
|
||
| it 'does not report an offense for a debugger or pry method' do | ||
| it 'does not report an offense for a debugger, byebug or pry method' do |
There was a problem hiding this comment.
I think you should split this into several separate examples (you can generate them on-the-fly with some loop).
|
Rebased on master, split the spec & fixed the changelog entry. |
| @@ -24,16 +30,18 @@ | |||
| expect(cop.offenses).to be_empty | |||
| end | |||
|
|
|||
| it 'does not report an offense for debugger in comments' do | |||
| src = ['# debugger'] | |||
| it 'does not report an offense for debugger or byebug in comments' do | |||
There was a problem hiding this comment.
I will split this example in 2 as well.
bbatsov
added a commit
that referenced
this pull request
Apr 7, 2014
Let the Debugger cop also check for byebug calls
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Byebug is a popular debugger that works with Ruby 2 (which Debugger doesn’t). Would it be ok to add a
byebugas we’ve done here, or should it rather be a separate cop?