Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllCops deprecation message shows the config path #971

Merged
merged 1 commit into from
Apr 8, 2014

Conversation

bcobb
Copy link
Contributor

@bcobb bcobb commented Apr 7, 2014

This was motivated by a project I'm working on that has a couple of .rubocop.yml configuration files. I periodically forget about the second of the two, and was initially confused by repeated deprecation warnings after upgrading and fixing what I thought was the only offense. In general, it seems like a nice gesture to provide users with the location of files which contain deprecated syntax.

I can squash in a Changelog update if this is deemed a good change.

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 7, 2014

The change is a good one. Mention in the changelog and we're good to go.

@bcobb
Copy link
Contributor Author

bcobb commented Apr 8, 2014

Squashed in a Changelog entry.

bbatsov added a commit that referenced this pull request Apr 8, 2014
AllCops deprecation message shows the config path
@bbatsov bbatsov merged commit e7e70d3 into rubocop:master Apr 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants