Fix bug with --auto-gen-config and RegexpLiteral #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `RegexpLiteral` cop stores a running tally of slashes found inside regular expressions, which it uses to determine whether the auto-generated config should disable the cop completely, or just specify the maximum number of slashes to make the cop pass. Previously this tally was stored in an instance variable. However, this doesn't work when run against a project with multiple files, because a new instance of the cop is created for each file. Thus, we need to store the running tally in a class-level variable.
|
👍 Looks good! Thanks for fixing. |
bbatsov
added a commit
that referenced
this pull request
May 30, 2014
…-gen Fix bug with --auto-gen-config and RegexpLiteral
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RegexpLiteralcop stores a running tally of slashes found insideregular expressions, which it uses to determine whether the
auto-generated config should disable the cop completely, or just specify
the maximum number of slashes to make the cop pass.
Previously this tally was stored in an instance variable. However, this
doesn't work when run against a project with multiple files, because a
new instance of the cop is created for each file. Thus, we need to store
the running tally in a class-level variable.
cc @tamird