Only check for modifier before def #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fphilipe
force-pushed
the
allow-modifier-before-def
branch
from
9121882 to
0d97899
Compare
Previously, only certain methods primarily related to method visibility were allowed before a `def`. This changes the behavior such that anything before `def` is allowed. Closes rubocop#1467
fphilipe
force-pushed
the
allow-modifier-before-def
branch
from
0d97899 to
bd86735
Compare
|
Looks good to me. @jonas054 WDYT? |
|
👍 Good! |
bbatsov
added a commit
that referenced
this pull request
Jul 2, 2015
Only check for modifier before def
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only certain methods primarily related to method visibility were allowed before a
def. This changes the behavior such that anything beforedefis allowed.Closes #1467