Allow enabling departments when DisabledByDefault is true #4304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas054
force-pushed
the
enable_dept_when_disabled_by_default
branch
from
87e9729 to
3dd559d
Compare
|
I just realized that I'm enabling all cops in the department, including the ones from |
jonas054
force-pushed
the
enable_dept_when_disabled_by_default
branch
from
3dd559d to
3600caa
Compare
|
There. I think it's all in order now. |
When DisabledByDefault is true, only cops explicitly enabled in user configuration are run. This should work for departments too.
jonas054
force-pushed
the
enable_dept_when_disabled_by_default
branch
from
3600caa to
a467d09
Compare
koic
added a commit
to koic/rubocop
that referenced
this pull request
Sep 26, 2024
Follow up rubocop#4304. This PR tweaks the doc for `DisabledByDefault: true` in configuration.
8 tasks
bbatsov
pushed a commit
that referenced
this pull request
Sep 26, 2024
Follow up #4304. This PR tweaks the doc for `DisabledByDefault: true` in configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
DisabledByDefaultistrue, only cops explicitly enabled in user configuration are run. This should work for departments too.