Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include .jb file by default #4385

Merged
merged 1 commit into from
May 21, 2017
Merged

Include .jb file by default #4385

merged 1 commit into from
May 21, 2017

Conversation

pocke
Copy link
Collaborator

@pocke pocke commented May 18, 2017

jb gem uses .jb extension.
https://github.com/amatsuda/jb

For example: ( https://github.com/amatsuda/jb#examples )

 # app/views/messages/show.json.jb

json = {
  content: format_content(@message.content),
  created_at: @message.created_at,
  updated_at: @message.updated_at,
  author: {
    name: @message.creator.name.familiar,
    email_address: @message.creator.email_address_with_name,
    url: url_for(@message.creator, format: :json)
  }
}

if current_user.admin?
  json[:visitors] = calculate_visitors(@message)
end

json[:comments] = @message.comments.map do |comment|
  {
    content: comment.content,
    created_at: comment.created_at
  }
end

json[:attachments] = @message.attachments.map do |attachment|
  {
    filename: attachment.filename,
    url: url_for(attachment)
  }
end

json

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests are passing.
  • The new code doesn't generate RuboCop offenses.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@@ -14,6 +14,7 @@ AllCops:
- '**/*.gemspec'
- '**/*.god'
- '**/*.jbuilder'
- '**/*.jb'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good to '**/*.jb' is above'**/*.jbuilder'.

 ['**/*.jbuilder', '**/*.jb'].sort # => ["**/*.jb", "**/*.jbuilder"]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koic Thanks! I've sorted it.

@bbatsov
Copy link
Collaborator

bbatsov commented May 18, 2017

Guess this should be added to the code that determines if something's Ruby or not as well.

jb gem uses `.jb` extension.
https://github.com/amatsuda/jb

For example: ( https://github.com/amatsuda/jb#examples )

```ruby
 # app/views/messages/show.json.jb

json = {
  content: format_content(@message.content),
  created_at: @message.created_at,
  updated_at: @message.updated_at,
  author: {
    name: @message.creator.name.familiar,
    email_address: @message.creator.email_address_with_name,
    url: url_for(@message.creator, format: :json)
  }
}

if current_user.admin?
  json[:visitors] = calculate_visitors(@message)
end

json[:comments] = @message.comments.map do |comment|
  {
    content: comment.content,
    created_at: comment.created_at
  }
end

json[:attachments] = @message.attachments.map do |attachment|
  {
    filename: attachment.filename,
    url: url_for(attachment)
  }
end

json
```
@pocke
Copy link
Collaborator Author

pocke commented May 21, 2017

I've added .jb to TargetFinder.

@bbatsov bbatsov merged commit dc94c1b into rubocop:master May 21, 2017
@pocke pocke deleted the jb-extension branch May 21, 2017 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants