Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lint/UnreachableCode aware of if and case #4529

Merged
merged 1 commit into from
Jun 18, 2017

Conversation

pocke
Copy link
Collaborator

@pocke pocke commented Jun 18, 2017

Currently, Lint/UnreachableCode cop does not add offense to the following code.

def some_method
  if cond
    return
  else
    return
  end
  do_something
end

However, the do_something is unreachable.

This change fixes the problem.


  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • All tests(rake spec) are passing.
  • The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

@pocke pocke force-pushed the Lint/UnreacableCode-fix branch from 376f437 to e9c27ba Compare June 18, 2017 06:16
Currently, `Lint/UnreachableCode` cop does not add offense to the following code.

```ruby
def some_method
  if cond
    return
  else
    return
  end
  do_something
end
```

However, the `do_something` is unreachable.

This change fixes the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants