Fix Style/LambdaCall to autocorrect obj.call to obj. #4604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iGEL
force-pushed
the
call_without_parens
branch
from
6ebc58c to
e4182b8
Compare
iGEL
changed the title
bbatsov
reviewed
Jul 14, 2017
lib/rubocop/cop/style/lambda_call.rb
Outdated
| @@ -40,11 +40,32 @@ def autocorrect(node) | |||
|
|
|||
| corrector.replace(node.source_range, replacement) | |||
| else | |||
| add_parenthesis(node, corrector) unless node.parenthesized? | |||
There was a problem hiding this comment.
@bbatsov Thanks, fixed!
The autocorrection of `Style/LambdaCall` generated invalid code when set to `braces` and the call didn't had parentheses (eg. `obj.call` was "corrected" to `obj.` instead of `obj.()`). The code partially comes from `Style/MethodCallWithArgsParentheses`.
iGEL
force-pushed
the
call_without_parens
branch
from
e4182b8 to
2c9f44a
Compare
5 tasks
This was referenced Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autocorrection of
Style/LambdaCallgenerated invalid code when set tobracesand the call didn't had parentheses (eg.obj.callwas "corrected" toobj.instead ofobj.()).The code partially comes from
Style/MethodCallWithArgsParentheses.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).rake spec) are passing.rake internal_investigation.and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).