Fix FIELD_REGEX for Lint/FormatParameterMismatch #4618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
reviewed
Jul 20, 2017
| @@ -85,6 +85,10 @@ | |||
| expect_no_offenses("format('%s %s %% %s %%%% %%%%%%', 1, 2, 3)") | |||
| end | |||
|
|
|||
| it 'correctly ignores CGI escaped brackets' do | |||
| expect_no_offenses("format('%s%%5B%s%%5D=%s', 'name', 'key', 'value')") | |||
There was a problem hiding this comment.
This test case is too complicated.I think format("%s%%5B", 'name') is enough.
And the description (correctly ignores ...) should be changed because the problem is not limited to CGI.
WDYT?
There was a problem hiding this comment.
I can just extend test case above with %%5B, would it be ok?
|
Good catch! |
Regex was missing escape for . (dot) and it was matching CGI-escaped left bracket used in format calls.
|
@pocke I have no idea where those failures come from, definitely not from my changes. Can we merge it like this? |
|
@barthez It's good that you're well connected. |
5 tasks
This was referenced Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regex was missing escape for . (dot) and it was matching CGI-escaped left bracket used in format calls.