Make Lint/RedundantWithIndex cop aware of offset argument
#4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up of rubocop#4796 (comment). Actually, it is only `with_index` method that accepts an offset argument. `with_with_index` method doesn't accept offset argument. However, I think that the same AST will be low maintenance cost.
koic
deleted the
make_lint_redundant_with_index_cop_aware_of_offset_arg
branch
Drenmi
reviewed
Nov 1, 2017
| @@ -69,7 +69,7 @@ def message(node) | |||
| end | |||
|
|
|||
| def with_index_range(send) | |||
| range_between(send.loc.selector.begin_pos, send.loc.selector.end_pos) | |||
| range_between(send.loc.selector.begin_pos, send.source.length) | |||
There was a problem hiding this comment.
This actually only works incidentally because processed_source happens to start at the beginning of the node, which is kind of frail. Would probably use send.loc.expression.end_pos instead of send.source.length.
There was a problem hiding this comment.
I opened a PR #4983. Thanks!
I think it's perfectly fine, since Hm. Except perhaps |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Nov 2, 2017
Follow up of rubocop#4977 (comment). This commit fixes the following potential problem. > This actually only works incidentally because processed_source happens > to start at the beginning of the node, which is kind of frail.
11 tasks
Oh... I overlooked this case 💦 I'd like to open a PR sometime. |
bbatsov
pushed a commit
that referenced
this pull request
Nov 2, 2017
Follow up of #4977 (comment). This commit fixes the following potential problem. > This actually only works incidentally because processed_source happens > to start at the beginning of the node, which is kind of frail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #4796 (comment).
Actually, it is only
with_indexmethod that accepts an offset argument.with_with_indexmethod doesn't accept offset argument.However, I think that the same AST will be low maintenance cost.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).rake spec) are passing.rake internal_investigation.and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).