-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most Read Page Dev A11y swarm #6185
Comments
❓ = Not done https://bbc.github.io/accessibility-news-and-you/accessibility-swarms Checklist - Manual
Checklist - Assistive TechnologyAcceptance criteria:
|
A11y complete for most read page, no issues found 🚀 |
Is your feature request related to a problem? Please describe.
Once the most read page is available on our TEST environment, we have to do a small A11y swarm to confirm h1 works as expected.
doc: https://bbc.github.io/accessibility-news-and-you/accessibility-swarms
most read available here: https://www.test.bbc.com/pidgin/popular/read
Initial a11y requirements for most read page:
Accessibility - Most read should be within the main container and the h1 should be visually displayed as ‘Most read’ and the skip to content link should anchor here (note there should not be an h2 for most read or any other regions for most read within the main region)
Describe the solution you'd like
Conduct an a11y swarm with 2-3 devs. Focus mainly on the a11y behavior of the h1. The most read component has already had a full a11y swarm.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Testing notes
[Tester to complete]
Dev insight: Will Cypress tests be required or are unit tests sufficient? Will there be any potential regression? etc
Additional context
Acceptance Criteria for skip to content:
The text was updated successfully, but these errors were encountered: