Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New Parcel Map Layer with PID Labels #363

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: New Parcel Map Layer with PID Labels #363

wants to merge 2 commits into from

Conversation

popkinj
Copy link
Collaborator

@popkinj popkinj commented Jan 24, 2025 •
edited by github-actions bot
Loading

  • I tried combining the labels and outlines into one layer.. But I couldn't convince the WMS service to do it. Plus, I don't think it's in the WMS Spec to combine styles in on request.
  • Combined the two new layers with the Crown land as they are from the same dataset.
    Screenshot from 2025-01-24 13-19-17

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@popkinj popkinj requested review from dawnbcgov and kdbelair January 24, 2025 21:25
@popkinj popkinj linked an issue Jan 24, 2025 that may be closed by this pull request
Map > Include layer with parcel / property lines (and ideally info on PIDs on hover) for map page #306
Open
3 tasks
@kdbelair
Copy link

kdbelair commented Jan 24, 2025 •
edited
Loading

  • I would propose we rename "Parcel Fabric - Outlined" to "Parcels - Outlined" and "Parcel Fabric - Labeled" to "Parcel IDs"
  • I believe these new layers makes the "Crown Provincial" redundant so we can remove
  • I am not sure if iMapBC and ORI is using a different layer, but when I compared two areas in Departure Bay, Nanaimo against each other, it appears as if ORI does not include PIDs for all the parcels compared to iMap. See screenshots for an example
    Parcels - iMapBC
    . See screenshots for an example
    Parcels - ORI

@popkinj
Copy link
Collaborator Author

popkinj commented Jan 24, 2025

  • I would propose we rename "Parcel Fabric - Outlined" to "Parcels - Outlined" and "Parcel Fabric - Labeled" to "Parcel IDs"

    • I believe these new layers makes the "Crown Provincial" redundant so we can remove

    • I am not sure if iMapBC and ORI is using a different layer, but when I compared two areas in Departure Bay, Nanaimo against each other, it appears as if ORI does not include PIDs for all the parcels compared to iMap. See screenshots for an example
      Parcels - iMapBC
      . See screenshots for an example
      Parcels - ORI

First and second points are done.
As for the iMap cross reference. They essentially use the same layer. What happens when you zoom in a bit on our map?

@kdbelair
Copy link

First and second points are done. As for the iMap cross reference. They essentially use the same layer. What happens when you zoom in a bit on our map?

This screenshot was taken at max zoom on ORI. Happy to share my screen. The changes to the layer names and and removal look good.

@kdbelair
Copy link

When you have finished with the layers, would you be able to provide me with the links to the BC Catalogue associated with each layer so we can document. Thank you.

@kdbelair
Copy link

Also noted that the "Indian Reserves" layer should be renamed to the following:
reserves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawnbcgov dawnbcgov Awaiting requested review from dawnbcgov

@kdbelair kdbelair Awaiting requested review from kdbelair

@mishraomp mishraomp Awaiting requested review from mishraomp mishraomp is a code owner

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

@AmanBhathal AmanBhathal Awaiting requested review from AmanBhathal AmanBhathal is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map > Include layer with parcel / property lines (and ideally info on PIDs on hover) for map page
2 participants
@popkinj @kdbelair