-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rationalize unison as CLI and unison-gui as GUI for program names in all builds #667
Comments
A complexity is that on Mac, one one build a Mac application, and the gtk version similar to other mostly-POSIX systems. |
See also #394, which points out that the GHA build process results in unison and unison-gtk, which is aligned with how several packaging systems approach unison. The point of this ticket is to change the build system to have separate binaries, and to be able to remove the workaround of renaming from GHA and packaging system builds. |
This implies a removal of "UISTYLE", and targets unison, unison-gui, and something for the mac package. The target unison-gui should just fail if lablgtk3 is not available. |
I have observed buggy behavior, all in src (because the top-level makefile does not work right with UISTYLE passthrough).
Basically, UISTYLE violates a basic rule of command-line variables (or environment vairables) and make: If you use them, you have to start from clean, and then on every later invocation of make the variable has to have the same value. That's not how the unison build system is used. |
This state should ensure as a side effect that CI artifacts will have a CLI binary that will work on a system without the GTK libraries, or with the misplaced or wrong kind of GTK libraries.
Keep in mind, thought, that unison doctrine is that CI is for CI and packaging systems should provide packages. However building from source should be clean and aligned with packaging norms, and that's what this ticket is about.
The text was updated successfully, but these errors were encountered: