Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labels kwarg for default_pod / K8sNativeManager / addprocs_pod #17

Open
kolia opened this issue Apr 9, 2021 · 2 comments
Open

labels kwarg for default_pod / K8sNativeManager / addprocs_pod #17

kolia opened this issue Apr 9, 2021 · 2 comments

Comments

@kolia
Copy link
Contributor

kolia commented Apr 9, 2021

Right now labels can be set by passing in a configure closure, which is clunky.

Users should be able to pass in labels as kwargs, the same way as memory, cpu, etc.

Maybe even set a label by default, maybe name: <driver-pod-id>?

@omus
Copy link
Member

omus commented Apr 23, 2021

Maybe even set a label by default, maybe name: <driver-pod-id>?

Some default labels would be nice. We should probably have a label that is used for the manager and worker pods (e.g. cluster: <driver-pod-id>) and a label just for the worker pods (e.g. worker: <driver-pod-id>).

The later already has a PR: #38

@omus
Copy link
Member

omus commented Apr 27, 2021

Workers now automatically have a worker-id label which is the same as there worker ID (myid) as of #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants