You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# Redirect any stdout/stderr from the worker to be displayed on the manager.
# Note: `start_worker` (via `--worker`) automatically redirects stderr to
# stdout.
p =open(detach(`$(kubectl()) logs -f pod/$pod_name`), "r+")
config =WorkerConfig()
config.io = p.out
It probably should default to true to match Base and to help when getting started, although I suspect many users will want to turn it off once their projects have reached some level of maturity.
Why would someone want to turn it off? Folks might already have logging setup on pods by default (like we do at Beacon), in which case having the manager's logs be filled by the workers + it's own is redundant and overly verbose, since you can easily get the workers logs by looking at their pod output. Additionally, the way Base uses this IO object is it prints the result, without using the logging system. That means there's no opportunity to customize or direct the output with the logging system.
The text was updated successfully, but these errors were encountered:
I.e. I think it would be great if the
manager
could store aBool
for whether or not we want to run these lines:K8sClusterManagers.jl/src/native_driver.jl
Lines 118 to 124 in 905c995
It probably should default to
true
to match Base and to help when getting started, although I suspect many users will want to turn it off once their projects have reached some level of maturity.Why would someone want to turn it off? Folks might already have logging setup on pods by default (like we do at Beacon), in which case having the manager's logs be filled by the workers + it's own is redundant and overly verbose, since you can easily get the workers logs by looking at their pod output. Additionally, the way Base uses this IO object is it prints the result, without using the logging system. That means there's no opportunity to customize or direct the output with the logging system.
The text was updated successfully, but these errors were encountered: