Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration option to not pass worker stdout/stderr back to manager #91

Open
ericphanson opened this issue Mar 5, 2022 · 1 comment

Comments

@ericphanson
Copy link
Member

I.e. I think it would be great if the manager could store a Bool for whether or not we want to run these lines:

# Redirect any stdout/stderr from the worker to be displayed on the manager.
# Note: `start_worker` (via `--worker`) automatically redirects stderr to
# stdout.
p = open(detach(`$(kubectl()) logs -f pod/$pod_name`), "r+")
config = WorkerConfig()
config.io = p.out

It probably should default to true to match Base and to help when getting started, although I suspect many users will want to turn it off once their projects have reached some level of maturity.

Why would someone want to turn it off? Folks might already have logging setup on pods by default (like we do at Beacon), in which case having the manager's logs be filled by the workers + it's own is redundant and overly verbose, since you can easily get the workers logs by looking at their pod output. Additionally, the way Base uses this IO object is it prints the result, without using the logging system. That means there's no opportunity to customize or direct the output with the logging system.

@jrevels
Copy link
Member

jrevels commented Mar 16, 2022

+1

xref JuliaLang/Distributed.jl#51 and other linked issues there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants