"keep array indentation" not working

[mvolkmann]

The two attached screen shots show some simple input and output that demonstrate the issue. Also notice the incorrect closing brace indentation for the objects inside the array property "two".

This is the input:

This is the output:

[mvolkmann]

I should add that what I expected was for no changes to be made to the input code.

[bitwiseman]

Input:

function foo() {
  return [
    {
      one: 'x',
      two: [
        {
          id: 'a',
          name: 'apple'
        },
        {
          id: 'b',
          name: 'banana'
        }
      ]
    }
  ];
}

Actual Output:

function foo() {
  return [{
      one: 'x',
      two: [
        {
          id: 'a',
          name: 'apple'
          },
        {
          id: 'b',
          name: 'banana'
          }
        ]
  }];
}

[bitwiseman]

Interesting bug.
All of these inputs work as expected - the input remains unchanged:

function foo() {
  return [{
    one: 'x',
    two: [
      {
        id: 'a',
        name: 'apple'
      },
      {
        id: 'b',
        name: 'banana'
      }
    ]
  }];
}

function foo() {
  a = [
    {
      one: 'x',
      two: [
        {
          id: 'a',
          name: 'apple'
        },
        {
          id: 'b',
          name: 'banana'
        }
      ]
    }
  ];
  return a;
}

foo(
  [
    {
      one: 'x',
      two: [
        {
          id: 'a',
          name: 'apple'
        },
        {
          id: 'b',
          name: 'banana'
        }
      ]
    }
  ]);

foo([
  {
    one: 'x',
    two: [
      {
        id: 'a',
        name: 'apple'
      },
      {
        id: 'b',
        name: 'banana'
      }
    ]
  }
]);

So, we have a hole in our test matrix, which maybe specific to the return statement logic.

[mvolkmann]

Did a recent change fix it? I cannot reproduce the problem in the Web UI
now.

On Thu, Nov 7, 2013 at 3:12 PM, Liam Newman [email protected]:

Interesting bug.
This code works - the input remains unchanged:

function foo() {
return [{
one: 'x',
two: [
{
id: 'a',
name: 'apple'
},
{
id: 'b',
name: 'banana'
}
]
}];}

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/333#issuecomment-28006791
.

R. Mark Volkmann
Object Computing, Inc.

[bitwiseman]

It's there, I can still repro it, double check your settings.

[mvolkmann]

Perhaps I misunderstood. I copied the code from your email today, pasted it
into the Web UI, kept all the default settings, and pressed the "Beautify"
button. I was expecting it to incorrectly change the indentation of the
closing array brace, but it didn't. I thought that indicated that the
problem has been fixed.

On Thu, Nov 7, 2013 at 3:53 PM, Liam Newman [email protected]:

It's there, I can still repro it, double check your settings.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/333#issuecomment-28010234
.

R. Mark Volkmann
Object Computing, Inc.