Add support for ES6 template strings #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same as previous. You munged a test and please implement in python. Should be trivial. |
|
What do you mean munged a test ? I suppose it's fixed now that python is done. |
|
No, there was a travis/npm dependency issue which I think I've worked around. This passed but other PRs failed. Amend and repush and travis will run them. |
|
This looks good to me. Again, you're reusing existing code that is pretty baked, so I'm comfortable taking it with fewer tests. We'll see if any issues come up. Thanks! |
bitwiseman
added a commit
that referenced
this pull request
Mar 26, 2014
Add support for ES6 template strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if this makes the support feature complete but at least it stops breaking template strings into multiple lines.