Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jsoneditor code and text mode options #217

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Add jsoneditor code and text mode options #217

merged 1 commit into from
Aug 5, 2020

Conversation

roark
Copy link
Contributor

@roark roark commented May 2, 2020 •
edited
Loading

Resolves #208 and #53

Adds code and text modes to the jsoneditor. (as well as original tree mode)

I also expanded the jsonEditor height to 300px. More vertical space was required for tree mode popover prompts and code / text editor parse warn messages.

Please let me know if there is anything else I can do to get this Pull Request merged in. Thanks for the useful tool.

@roark
Copy link
Contributor Author

roark commented May 2, 2020

example

@roark roark force-pushed the jsoneditor-modes branch 2 times, most recently from 1767cc9 to 3e248fa Compare May 6, 2020 06:36
@Chathula
Copy link

Chathula commented May 7, 2020 •
edited
Loading

This is the most awaited feature :D

@LewisJEllis, @skeggse can we get this merged?

@skeggse skeggse force-pushed the jsoneditor-modes branch 2 times, most recently from 3e248fa to 2d68a56 Compare August 5, 2020 02:03
@skeggse skeggse self-requested a review August 5, 2020 02:03
@skeggse skeggse self-assigned this Aug 5, 2020
@skeggse skeggse added this to the 3.1.0 milestone Aug 5, 2020
@skeggse skeggse merged commit 63ca0c8 into bee-queue:master Aug 5, 2020
beequeueci pushed a commit that referenced this pull request Aug 5, 2020
@semantic-release-bot
chore(release): 3.1.0 [skip ci]
a6a022c 
## [3.1.0](v3.0.2...v3.1.0) (2020-08-05)

### Features

* **add-job:** add jsoneditor code and text modes ([#217](#217)) ([63ca0c8](63ca0c8))
* **job-details:** show raw progress when not numeric ([bd0d697](bd0d697))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeggse skeggse skeggse approved these changes

Assignees

@skeggse skeggse

Labels
enhancement
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Ability to add raw json jobs
3 participants
@roark @Chathula @skeggse