Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for bullmq #251

Merged
merged 4 commits into from
Nov 1, 2020
Merged

add support for bullmq #251

merged 4 commits into from
Nov 1, 2020

Conversation

gtpan77
Copy link
Contributor

@gtpan77 gtpan77 commented Oct 17, 2020

Support for bullmq

issue: #248

Pending changes -
@types/bull-arena in DefinitelyTyped

@gtpan77
Copy link
Contributor Author

gtpan77 commented Oct 20, 2020

@skeggse, please review this PR.

@gtpan77
Copy link
Contributor Author

gtpan77 commented Oct 20, 2020

Copy link
Member

@skeggse skeggse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to actually use the BullMQ constructor over here, I think.

let queue;
if (isBee) {
_.extend(options, {
isWorker: false,
getEvents: false,
sendEvents: false,
storeJobs: false,
});
const { Bee } = this._config;
queue = new Bee(name, options);
queue.IS_BEE = true;
} else {
if (queueConfig.createClient) options.createClient = queueConfig.createClient;
const { Bull } = this._config;
queue = new Bull(name, options);
}

@gtpan77
Copy link
Contributor Author

gtpan77 commented Oct 21, 2020

I'll submit requested changes within two days

@gtpan77 gtpan77 requested a review from skeggse November 1, 2020 17:51
Copy link
Member

@skeggse skeggse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, though I don't know whether there are additional places we might need to add bullmq support. I think it's probably best to label this as preliminary support for bullmq, and we'll get feedback if there are missing features.

We'll also want to document usage in the README - if you're able, I'd be happy to accept a PR that does that.

@skeggse skeggse merged commit 1159dde into bee-queue:master Nov 1, 2020
beequeueci pushed a commit that referenced this pull request Nov 1, 2020
## [3.4.0](v3.3.3...v3.4.0) (2020-11-01)

### Features

* **bullmq:** initial support for bullmq ([#251](#251)) ([1159dde](1159dde))
@beequeueci
Copy link
Collaborator

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gtpan77
Copy link
Contributor Author

gtpan77 commented Nov 2, 2020

Thanks @skeggse, Yeah still there is a more to add for bullmq support. It will be my pleasure to contribute toward document usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants