-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for bullmq #251
Conversation
c173e03
to
9afaa5f
Compare
@skeggse, please review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to actually use the BullMQ
constructor over here, I think.
arena/src/server/queue/index.js
Lines 79 to 96 in 2a268c3
let queue; | |
if (isBee) { | |
_.extend(options, { | |
isWorker: false, | |
getEvents: false, | |
sendEvents: false, | |
storeJobs: false, | |
}); | |
const { Bee } = this._config; | |
queue = new Bee(name, options); | |
queue.IS_BEE = true; | |
} else { | |
if (queueConfig.createClient) options.createClient = queueConfig.createClient; | |
const { Bull } = this._config; | |
queue = new Bull(name, options); | |
} |
I'll submit requested changes within two days |
11317a9
to
9046470
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, though I don't know whether there are additional places we might need to add bullmq support. I think it's probably best to label this as preliminary support for bullmq, and we'll get feedback if there are missing features.
We'll also want to document usage in the README - if you're able, I'd be happy to accept a PR that does that.
## [3.4.0](v3.3.3...v3.4.0) (2020-11-01) ### Features * **bullmq:** initial support for bullmq ([#251](#251)) ([1159dde](1159dde))
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks @skeggse, Yeah still there is a more to add for bullmq support. It will be my pleasure to contribute toward document usage. |
Support for bullmq
issue: #248
Pending changes -
@types/bull-arena in DefinitelyTyped