Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed job listing for Bull #271

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

rafaelrpinto
Copy link
Contributor

@rafaelrpinto rafaelrpinto commented Oct 29, 2020

When attempting to access job details by status using [email protected] and [email protected] the following exception is thrown:

   (node:43624) UnhandledPromiseRejectionWarning: TypeError: function is not iterable (cannot read property Symbol(Symbol.iterator))
    at Function.all (<anonymous>)
    at _html (/work/xxxxxxxx/xxxxxxxx/xxxxxxxx/node_modules/bull-arena/src/server/views/dashboard/queueJobsByState.js:105:15)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:43624) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:43624) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:43624) UnhandledPromiseRejectionWarning: TypeError: #<Promise> is not a function
    at Array.map (<anonymous>)
    at _html (/work/xxxxxxxx/xxxxxxxx/xxxxxxxx/node_modules/bull-arena/src/server/views/dashboard/queueJobsByState.js:104:16)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
(node:43624) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)

This PR fixes the bug on the Promise.all usage and makes the list accessible again.

@skeggse skeggse merged commit 6e205a6 into bee-queue:master Oct 29, 2020
beequeueci pushed a commit that referenced this pull request Oct 29, 2020
### [3.3.3](v3.3.2...v3.3.3) (2020-10-29)

### Bug Fixes

* **job-details:** actually correctly wait for promises ([#271](#271)) ([6e205a6](6e205a6))
@beequeueci
Copy link
Collaborator

🎉 This PR is included in version 3.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants