Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary spacing in CLI output #885

Closed
ben-wallis opened this issue May 2, 2023 · 3 comments
Closed

Unnecessary spacing in CLI output #885

ben-wallis opened this issue May 2, 2023 · 3 comments

Comments

@ben-wallis
Copy link

After spending 30 minutes trying to figure out why csharpier was formatting a different number of files in our CI pipeline than locally, I finally noticed that my browser window was the exact width that resulted in chopping the Total time and Total files output numbers in half:

image

It may be worth considering removing the spacing to prevent this kind of misreading of the output.

@belav belav added area:cli type:enhancement New feature or request labels May 4, 2023
@belav
Copy link
Owner

belav commented May 4, 2023

I've been considering simplifying the output for check and getting rid of the stats, I'm not sure that they add value. Prettier only provides a simple "everything is good" or "here are the files that aren't formatted" output. Maybe adding an option to show more details about the number of files, etc. If I do keep around the details I'll clean up the spacing to avoid this problem.

@belav
Copy link
Owner

belav commented May 22, 2023

Related #875

@belav
Copy link
Owner

belav commented May 22, 2023

I'm going to rework the logging and add a logging level with #875. As part of that the format is going to change which will remove this problem.

@belav belav closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants