Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images not containing JavaFX #84

Open
nicolabeghin opened this issue May 20, 2022 · 5 comments
Open

Docker images not containing JavaFX #84

nicolabeghin opened this issue May 20, 2022 · 5 comments

Comments

@nicolabeghin
Copy link

nicolabeghin commented May 20, 2022

Hi everyone
I see that JavaFX is excluded from Docker images - checked JDK 11 and 17, both on Alpine/Debian/CentOS.

ref. https://github.com/bell-sw/Liberica/blob/master/docker/repos/liberica-openjdk-debian/17/Dockerfile#L155

MODS=$( ls ${UNPACKED_ROOT}/jmods/          \
      | sed "s/.jmod//"                     \
      | grep -v javafx                      \
      | tr '\n' ', '                        \
      | sed "s/,$//")                       \

Any reason behind this?

thanks
nicola

@nicolabeghin
Copy link
Author

nicolabeghin commented May 21, 2022

If useful, here's a small bash script to build Liberica Docker images with javafx enabled, based on original Liberica-provided Dockerfile

https://github.com/nicolabeghin/liberica-openjdk-with-javafx

@voitylov
Copy link
Collaborator

thanks for sharing, the Dockerfiles are provided exactly for the purpose of making such customizations possible.

Our major focus is on keeping the base Liberica image size small, thus we currently do not plan to include FX in the base Liberica image.

It would be interesting to understand the specific use case for JDK with FX inside docker images, if we may be underestimating how wide-spread such a use case is.

@nicolabeghin
Copy link
Author

Thanks, my use case is to build desktop JavaFX apps in the existing CI/CD tool (Gitlab in this case).

@Goldenflamer
Copy link

Goldenflamer commented Apr 9, 2023

This would be really needed and it is not a big thing to add.
Adding an environment variable that triggers if the "-full" String is attached to the download path is all that is needed to support JavaFX in docker.

Many applications need this in CI pipelines etc.

For example, the only thing changing would be from this URL:
https://download.bell-sw.com/java/8u362+9/bellsoft-jre8u362+9-linux-amd64.tar.gz
to this URL
https://download.bell-sw.com/java/8u362+9/bellsoft-jre8u362+9-linux-amd64**-full**.tar.gz

via an optional environment variable in the Dockerfile for every tag.

@salzig
Copy link

salzig commented Aug 15, 2024

I just stumbled upon this issue, and was surprised that there is no -full or -standard prebuild image variants available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants