-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AppVeyor for testing on Win #26
Comments
You can try and write your results here. But we use nodejs api for path building and we believe it have to work right. |
@awinogradov I wrote here, cause I've tried already :) |
Ok) we can wait) |
В общем решил этот ишью для себя, захотел сделать PR и обнаружил, что у меня версия 0.0.2 :) Так что, наверное, можно закрывать, но на будущее иметь в виду :) |
Let's keep this issue, and add CI for windows |
adding Should I make a PR with this change? |
Hmm. I think "required-path" package is more suitable place to fix it. |
Ok. Investigated a bit more. The problems starts when we replacing node with requires using generators. I see now 3 potential places to put fix:
I like first one. The only problem I see here, is that purpose of What do you think guys? |
One more suggestion: Yeti-or/required-path#3 (comment) |
Still waiting for PR ;) |
still waiting an answer from @Yeti-or |
It seems there are some troubles with path resolving on Windows
import BPage from 'b:b-page';
It will eat Win slashes and path to this block won't be resolved.
The text was updated successfully, but these errors were encountered: