-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HopperMuJoCoEnv #54
Comments
This repo is for mujoco envs TRANSFERRED into pybullet envs. Mujoco is not free, and you will not be able to do mujoco with this repo |
Hi, I know that and I referred to the Mujoco implementations of pybullet -> https://github.com/benelot/pybullet-gym/blob/master/pybulletgym/envs/mujoco/envs/locomotion/hopper_env.py. Indeed, pybullet implements both its own imlementation and the "Mujoco copies" for most of the environments. Here, the problem was that the Mujoco implementation above returned the pybullet implementation. After having written this post, I found out the source of the problem. In the second line of hopper_env.py is imported the roboschool locomotor instead of the Mujoco one. Solving the issue is as simple as it follows:
Hope this will help someone else. |
Hello @giarcieri |
Hi @benelot! |
Thanks, merged! |
Hello @giarcieri, thank you for your work, it definitely serves as a test to my environments. If you are up to it, I would love to have some baselines for my repositories in the tests folder. This would include saving some of your trained agents and loading them in the test and run it, check for some average performance score and add it to the test to only pass if it stays above the performance score. Like that it would be clear that all of them work perfectly. I also never checked if the performances can be compared to the baselines on the actual mujoco envs, they are just as close as possible in observations and actions. As you correctly found out, in some cases, we are still missing the correspondance in the observation, and instead zeroes were added to comply with the number of observations. That is definitely something to investigate in the future and I am sorry if it caused some inconvenences! |
Hi @benelot, |
Hi and thank you very much for your work,
I would like to use the MuJoCo implementation of Hopper, which has obs_dim=11 and action_dim=3. However, when making the environment with gym.make('HopperMuJoCoEnv-v0'), it returns the PyBullet implementation (HopperPyBulletEnv-v0) which has obs_dim=15 and action_dim=3. Is it possible to access the MuJoCo implementation (https://github.com/benelot/pybullet-gym/blob/master/pybulletgym/envs/mujoco/envs/locomotion/hopper_env.py)?
The text was updated successfully, but these errors were encountered: