Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address single table polymorphism inconsistencies #285

Merged
merged 6 commits into from
Apr 17, 2023

Conversation

benjie
Copy link
Member

@benjie benjie commented Apr 17, 2023

For columns that aren't exposed in all types:

  • relations dependent on these columns are only exposed on the relevant types; and there is no reverse relation
  • ordering by these columns is now removed
  • filtering by these columns is now removed

Removing things leaves us space to add them back in, in the right places, in future.

Fixes #277

@benjie benjie merged commit 0adc0a6 into planning Apr 17, 2023
@benjie benjie deleted the polymorphic-single-relation branch April 17, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant