-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Even more TODOs still; plus Grafserv exports #408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teBaseName` and `getBaseNameFromKeys` inflectors to all begin with an underscore (`_`) - this is because these inflectors should only be used from other inflectors, since they may return non-string types (null/boolean/etc).
…nce, other errors should still throw.
…tOutputTypeByName.
… omits the QueryPlugin, and raise an error or warning indicating to the user that there's likely an issue here.
…pare to ensure stable ordering across machines.
…dataplan/pg' module
… seconds unless you configure it to do so. New watch mode _untested_.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getBaseName
,baseNameMatches
,getOppositeBaseName
andgetBaseNameFromKeys
inflectors to all begin with an underscore (_
) - this is because these inflectors should only be used from other inflectors, since they may return non-string types (null/boolean/etc).getBaseName
->_getBaseName
, etc.@dataplan/pg
to follow the conventions:*Extensions
exports from@dataplan/pg
to be in global namespaceDataplanPg
:PgCodecExtensions
->DataplanPg.PgCodecExtensions
PgCodecAttributeExtensions
->DataplanPg.PgCodecAttributeExtensions
PgCodecRelationExtensions
->DataplanPgCodecRelationExtensions
PgCodecRefExtensions
->DataplanPg.PgCodecRefExtensions
PgRefDefinitionExtensions
->DataplanPg.PgRefDefinitionExtensions
PgResourceExtensions
->DataplanPg.PgResourceExtensions
PgResourceUniqueExtensions
->DataplanPg.PgResourceUniqueExtensions
PgResourceParameterExtensions
->DataplanPg.PgResourceParameterExtensions
PgConditionStepExtensions
->DataplanPg.PgConditionStepExtensions
en-US
localetamedevil
exporttoJSON
renamed tostringifyJSON
(for clarity)tamedevil
methoddangerousKey
renamed tosafeKeyOrThrow
(for clarity)@grafserv/persisted
now allows configuring the poll interval of the persisted operations folder, and even adds (untested) watch mode (preset.grafserv.persistedOperationsDirectoryScanInterval = number | "watch"
(number is in milliseconds,-1
to disable polling/watching))Accept
header parser implements more of the specgrafserv
exports to make it easier to implement an alternative Grafserv adaptor:hash = sha1(String(error))
) in addition to the code, this allows grouping similar errors together (there is a small risk that an extremely highly motivated hacker could use this basic hashing (using the deprecated/broken SHA1 algorithm) to determine the underlying error and stack, but doing so would be incredibly resource intensive if it's even feasible at all).getOutputTypeByName
andgetInputTypeByName
__proto__
key ingraphile-export