Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global Symbol.observable typings #29

Merged
merged 2 commits into from
Dec 9, 2016
Merged

Fix global Symbol.observable typings #29

merged 2 commits into from
Dec 9, 2016

Conversation

benlesh
Copy link
Owner

@benlesh benlesh commented Dec 9, 2016

This is a continuation of #28.

  • updates TypeScript to 2.0+
  • fixes global type definition for Symbol.observable

appsforartists and others added 2 commits December 6, 2016 16:59
- update TS to 2.0+
- fixes typings to include global Symbol.observable symbol

closes #27
@benlesh benlesh changed the title Fix typings Fix global Symbol.observable typings Dec 9, 2016
@benlesh benlesh merged commit cbdfd37 into master Dec 9, 2016
@appsforartists
Copy link
Contributor

Now you just need a new release :)

@benlesh
Copy link
Owner Author

benlesh commented Dec 9, 2016

@appsforartists I'm waiting to see if we can get the UMD stuff cleared up. I'll maybe see if I can do that tomorrow.

@appsforartists
Copy link
Contributor

What, you mean I shouldn't just wrap it in an IIFE and inline it into my concatenated file? 😄

https://github.com/material-motion/indefinite-observable-js/blob/develop/dist/indefinite-observable.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants