From 21d6287e15fb6a96ce64e1006281d4d9de135ff3 Mon Sep 17 00:00:00 2001 From: Jun Date: Wed, 30 Oct 2019 16:16:07 +0800 Subject: [PATCH] Fix fdopen RuntimeWarning in 3.8 (#2146) --- gunicorn/workers/workertmp.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gunicorn/workers/workertmp.py b/gunicorn/workers/workertmp.py index a37ed1558..c475a12b8 100644 --- a/gunicorn/workers/workertmp.py +++ b/gunicorn/workers/workertmp.py @@ -32,7 +32,9 @@ def __init__(self, cfg): try: if not IS_CYGWIN: util.unlink(name) - self._tmp = os.fdopen(fd, 'w+b', 1) + # In Python 3.8, open() emits RuntimeWarning if buffering=1 for binary mode. + # Because we never write to this file, pass 0 to switch buffering off. + self._tmp = os.fdopen(fd, 'w+b', 0) except: os.close(fd) raise