-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 19.8.0 #1634
Comments
I would like to get the following PRs merged for 19.8:
|
@berkerpeksag i commented/approved then. Let me know if you need some help as I may have some cycles tomorrow :) |
I have open PRs. Do we want to merge any of them?
|
Both PRs good to have if we have time to get them in. |
Mine are in. Can I help with reviewing anything? |
#1499 is the only remaining one. I've addressed my review comments. |
@berkerpeksag i've commented also, what do you think about it? |
@berkerpeksag i didn't get an answer about #1499 . I'm dubious about putting back a eature that have been removed a long itme ago. We should see the pro/cons about it. Or at least makng sure it has no impact. I think however that before releasing i will disable by defaut the SO_REUSEPORT option of the socket. Thoughts? |
@benoitc I'm not sure I understand - why would we want to change the default for (We do rely on |
Having SO_REUSEPORT as a default seems to confused some people, especially those new to Gunicorn or using it in a development environment. It makes it possible to start a new Gunicorn without killing the old one, resulting in multiple versions of an application running. This is not a very friendly experience for a first time user who wonders why their application serves the right response only half of the time. We will definitely not remove the functionality even if we change the default. |
Looking at #1499 again, I'm fine with closing it as 'wontfix'. Making it compatible with Gunicorn 19.4+ is pretty trivial: - '-c', 'airflow.www.gunicorn_config'
+ '-c', 'python:airflow.www.gunicorn_config' |
on my todo list before any release I have the following:
i will try to have something for friday now |
Is there any more news on this? |
I think we also need to document the |
Wow, thanks for the quick response. 💯 |
Knowing asking ETA's is the greatest sin of all, are there any news on progress of #1653 which seems to be left blocking the release? |
There's an almost ready PR for #1324: |
I am fine to skip #1653 |
I don't see any reason to not release more often :) If I don't came with a patch by today let's release tomorrow in the morning. About that pyc stuff, i would be for fixing it in the current release and not adding any new option. I would rather deprecate this feature as it breaks the contract of auto reloading the config and such things. |
Pypi seems to be still at 19.7.1 https://pypi.python.org/pypi/gunicorn |
Sorry to bump, any news about the 19.8 release ? I'm eager to play with dictConfig :-) |
Any update on this? I'm looking forward to it since it fixes some issues with |
I'll prepare a release. @berkerpeksag @benoitc good for you? |
@tilgovi +1 from me. |
Out of curiosity, what kind of process making a gunicorn release is? |
It's not hard, but all of us do this on a volunteer basis. |
I've updated the changelog and I believe everything is prepped for release. I'm going to sleep and will cut the tag in the morning, when I can be around in case of any mistake that requires a followup patch release, but I don't expect any issues. |
19.8.0 is released! Please comment here with any feedback or issues! |
We're going to aim for more frequent releases going forward. Your pull requests and reviews help. If you're interested in being a maintainer, let me know! |
@tilgovi thank you! and agree :) sorry to not have answered soon I was traveling all the month |
As I would like to release a 19.8 version this week. I don't see anything preventing it right now. Tests pass here but let me know if I missed something.
The text was updated successfully, but these errors were encountered: