Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the description of GOOD_JOB_EXECUTION_MODE in the readme correct? #1584

Open
jdudley1123 opened this issue Jan 24, 2025 · 1 comment
Open

Comments

@jdudley1123
Copy link

jdudley1123 commented Jan 24, 2025

Should this line in the readme:

GOOD_JOB_EXECUTION_MODE=async rails server

actually just be GOOD_JOB_EXECUTION_MODE=async without rails server?

The section later on about available configuration options suggests yes, as it lists :async (with colon) as an option, but doesn't mention include rails server.

Having tested it, GOOD_JOB_EXECUTION_MODE=async seems to work fine. Adding rails server doesn't seem to work. I haven't tried it with a colon.

@bensheldon
Copy link
Owner

GOOD_JOB_EXECUTION_MODE=async rails server should set the execution mode to async and run your rails webserver, unless you've explicitly overridden the GoodJob execution mode in your application configuration.

The rails server part is intended to be an example of running a command from the command line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Inbox
Development

No branches or pull requests

2 participants