Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't restart the hub pod for image changes during deploy #2781

Open
yuvipanda opened this issue Sep 20, 2021 · 1 comment
Open

Don't restart the hub pod for image changes during deploy #2781

yuvipanda opened this issue Sep 20, 2021 · 1 comment
Labels
automation Manual things that shouldn't be

Comments

@yuvipanda
Copy link
Contributor

In #2677, the hub pod restarted during a deployment to pick up new image tag. This is not strictly necessary - we can add a feature to z2jh that prevents hub pod restarts for image tag changes. Let's do that so we don't restart the hub pod unnecessarily, reducing risk surface for bugs triggered by pod restarts.
@yuvipanda yuvipanda mentioned this issue Sep 20, 2021
Closed
@felder felder mentioned this issue Sep 20, 2021
Closed
@balajialg balajialg added the automation Manual things that shouldn't be label Sep 21, 2021
@balajialg
Copy link
Contributor

Thanks, @yuvipanda! Super critical change.

@yuvipanda yuvipanda removed their assignment Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automation Manual things that shouldn't be
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuvipanda @balajialg