Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X9D+ - virtual events lua still not correct #255

Closed
RipperDrone opened this issue Oct 10, 2019 · 6 comments
Closed

X9D+ - virtual events lua still not correct #255

RipperDrone opened this issue Oct 10, 2019 · 6 comments

Comments

@RipperDrone
Copy link
Contributor

RipperDrone commented Oct 10, 2019

@raphaelcoeffic @mikeller sry to report non-working fix for Lua - PIDs adjustment.

To replicate:

  • flash OTX 2.3.1 onto Taranis X9D+
  • flash latest / toay's Nightly OMNINXTF7 FW with BFC 10.6.0RC2
  • load latest today's lua onto Taranis (delete all .luac files on Taranis, let them recompile automatically by Taranis when switching on) from repository's /src directory
  • long press PAGE to get into telemetry page, short press to get on PID manipulation page
  • edit first field, press '-' --> Field value decrements ok
  • press 'ENTER' --> field value jumps back to old value

Same thing happens when incrementing the value first, it then jumps back down again.

Funnily, in repeating this procedure, 2nd time trying to change the same value, it retains the change.

@mikeller you reported the script working ok. Any difference btw your test sequence and mine?

@mikeller
Copy link
Member

Thanks @RipperDrone. I just verified again, and it's working fine on X9D+ with 2.3.0 - looks like they've broken it in the changes for 2.3.1. ☹️

@raphaelcoeffic
Copy link
Member

Really strange, it’s working fine in the Simu in 2.3.1. @RipperDrone did you try with the code from the other PR?

@robschii
Copy link

in als menus of the lua script als values jump back to the value before... i will stay at opentx 2.2.4

@RipperDrone
Copy link
Contributor Author

@raphaelcoeffic pls specify 'other PR' a little more. I have tested with y'day's .zip download of master, so both PRs should have been included in the /src directory, shouldn't they?

@raphaelcoeffic
Copy link
Member

raphaelcoeffic commented Oct 12, 2019

@RipperDrone sorry, I meant #250. Please note that the ZIP file is outdated. Just use the files in src/. Please note that the current master does not use virtual events as stated in the title of this issue. #250 does.

@RipperDrone
Copy link
Contributor Author

Success! Working now that I downloaded the /src files from the correct branch. Thank you @raphaelcoeffic - and closing this issue accordingly.

Now we have to handle the 'background noise' from people NOT matching the correct versions of lua and OTX - hope there is a consistent way out :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants