Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look into sorting rendering pipelines by bindgroups. #11715

Open
Elabajaba opened this issue Feb 5, 2024 · 0 comments
Open

Look into sorting rendering pipelines by bindgroups. #11715

Elabajaba opened this issue Feb 5, 2024 · 0 comments
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible C-Performance A change motivated by improving speed, memory usage or compile times D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon

Comments

@Elabajaba
Copy link
Contributor

What problem does this solve or what need does it fill?

This could make bevy's renderer faster.

I removed this from #11671 despite looking promising on initial benchmarks as I felt it needed more benchmarking, and I didn't have the time to get it working without a potentially crashy unwrap().

In a similar vein, we should also see if we can try and move back to radix sort somehow for sorting pipelines, as it was faster for the initial sorting but didn't support the types we're sorting now in #11671 and #11647
@Elabajaba Elabajaba added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Feb 5, 2024
@JMS55 JMS55 added A-Rendering Drawing game state to the screen A-Reflection Runtime information about types and removed S-Needs-Triage This issue needs to be labelled A-Reflection Runtime information about types labels Feb 5, 2024
@JMS55 JMS55 added this to the 0.14 milestone Feb 5, 2024
@alice-i-cecile alice-i-cecile added the C-Performance A change motivated by improving speed, memory usage or compile times label Feb 5, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes labels May 16, 2024
@alice-i-cecile alice-i-cecile removed this from the 0.14 milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible C-Performance A change motivated by improving speed, memory usage or compile times D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Elabajaba @alice-i-cecile @JMS55