Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to load an asset file should resut in some form of error message #479

Closed
fNek opened this issue Sep 12, 2020 · 3 comments
Closed
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Code-Quality A section of code that is hard to understand or change

Comments

@fNek
Copy link

fNek commented Sep 12, 2020

Steps to reproduce:

  1. Copy the code from examples/2d/sprites.rs into a new bevy project
  2. Intentionally save the bevy logo, which this example depends upon, under a different file name
  3. Forget to change the path in the code you copied
  4. Wonder why nothing is shown in the window

I believe there should be an error message printed to stderr or something, since it might easily happen under circumstances where it's less obvious what happened.

@Moxinilian Moxinilian added A-Assets Load files from disk to use for things like images, models, and sounds C-Code-Quality A section of code that is hard to understand or change labels Sep 12, 2020
@cart
Copy link
Member

cart commented Sep 14, 2020

Agreed. We currently swallow these error messages and that certainly isn't ideal 😄

@zicklag
Copy link
Member

zicklag commented Jan 27, 2021

I think this can be closed now. We get panics, I think, for failed asset loads now, and in master we actually don't get the panics for hot reload failures, we get nice warnings.

Edit: Even better looks like we get warnings for failed assets after this: #1286.

@cart
Copy link
Member

cart commented Jan 27, 2021

Makes sense to me!

@cart cart closed this as completed Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Development

No branches or pull requests

4 participants