Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow systems in a chain to access the name of the outer ChainSystem #5777

Open
JoJoJet opened this issue Aug 23, 2022 · 0 comments
Open

Allow systems in a chain to access the name of the outer ChainSystem #5777

JoJoJet opened this issue Aug 23, 2022 · 0 comments
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible

Comments

@JoJoJet
Copy link
Member

JoJoJet commented Aug 23, 2022

What problem does this solve or what need does it fill?

When chaining systems together (especially generic systems), it would be useful to get more detailed debug information about which other systems it is currently being chained with.

What solution would you like?

Some sort of extension to the SystemName param from #5731. Ideally, there would be a method outer_system_name, which returns the name of the ChainSystem if the system is in a chain, or None otherwise. This could also be used if we ever add more ways of composing systems.

What alternative(s) have you considered?

We could provide a SystemParam that gives debug info about the previous system in the chain. I don't like this as much.

Additional context

Would improve the panic messages in #5776.

@JoJoJet JoJoJet added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Aug 23, 2022
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events and removed S-Needs-Triage This issue needs to be labelled labels Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants