[model generator] Get rid of the AllOf classes

[lburgazzoli]

The ConnectorDeployment metadata is defined as ConnectorDeploymentAllOfMetadata where tha "AllOf" adds nothing:

public class ConnectorDeployment {
  public static final String JSON_PROPERTY_METADATA = "metadata";
  private ConnectorDeploymentAllOfMetadata metadata;

We should investigate if simpler names are possible, like ConnectorDeploymentMetadata

[dhirajsb]

@lburgazzoli I looked into this in detail. The AllOf classname generation is baked into the Java code that create type names. So, overriding it would require writing a new custom generator written in Java, perhaps inheriting the existing Java generator.

It turns out there is also an open issue in the generator for why these classes are generated. There is a workaround that requires modifying our openapi definitions to move properties from out of allOf and into the root of the outer object, e.g.:

     ConnectorTypeList:
       allOf:
         - $ref: '#/components/schemas/List'
-        - type: object
-          properties:
-            items:
-              type: array
-              items:
-                allOf:
-                  - $ref: '#/components/schemas/ConnectorType'
+      type: object
+      properties:
+        items:
+          type: array
+          items:
+            allOf:
+              - $ref: '#/components/schemas/ConnectorType'
+

But, the original definition seems to be the way the openapi spec suggests property inheritance should be done. So, I'm not sure whether we should be deviating from the spec and change our model definitions or live with the genreated AllOf class names.

[lburgazzoli]

thx for the investigation, let's keep them then