Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve matching of implementation accuracy #14

Open
bat52 opened this issue Oct 19, 2024 · 1 comment
Open

improve matching of implementation accuracy #14

bat52 opened this issue Oct 19, 2024 · 1 comment
Assignees

Comments

@bat52
Copy link
Collaborator

bat52 commented Oct 19, 2024

cadquery and solidpython .stl output files are generally much bigger than trimesh. This is due to the different default accuracy settings.

Particularly,

  • 'T-splinerev.stl' (trimesh): ~80kB
  • 'C-splinerev.stl' (cadquery) : ~900kB
  • 'S-splinerev.stl' (solidpython): ~200kB.

It can be seen by visual inspection that this is related to different accuracy on the output shape.
Similar differences are visible for 'rndrod'.

This results in an overall file size of the default output of:

  • trimesh: 2.2 MB
  • blender: 2.3MB
  • solidpython: 8.4MB
  • cadquery: 13.3MB

I think we should try to reduce accuracy for solidpython and cadquery.

@bguan bguan self-assigned this Oct 21, 2024
@bat52
Copy link
Collaborator Author

bat52 commented Nov 6, 2024

this can now routinely be checked looking at test_report.csv and/or test_report.xlsx, following this commit bat52@364168c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants