You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe that most benchmarking of Tokio-based usage will yield figures that are significantly incorrect. This is due to Tokio's block_on's future not being executed as a worker task. More information is here: tokio-rs/tokio#5446
Would a PR be welcome where we address this issue, perhaps by requiring Criterion's block_on to have a result with Send and then performing a spawn? Alternatively, a new block_on_worker method?
My Criterion-based benchmarks made me spend hours working out why my library was slow, when in fact it turned out to be the way I was using Tokio with block_on.
The text was updated successfully, but these errors were encountered:
I believe that most benchmarking of Tokio-based usage will yield figures that are significantly incorrect. This is due to Tokio's
block_on
's future not being executed as a worker task. More information is here: tokio-rs/tokio#5446Would a PR be welcome where we address this issue, perhaps by requiring Criterion's
block_on
to have a result withSend
and then performing a spawn? Alternatively, a newblock_on_worker
method?My Criterion-based benchmarks made me spend hours working out why my library was slow, when in fact it turned out to be the way I was using Tokio with
block_on
.The text was updated successfully, but these errors were encountered: