From 471026531eee54bec70cb2a5462057629d7be080 Mon Sep 17 00:00:00 2001 From: bhushan354 Date: Sat, 14 Oct 2023 20:53:52 +0530 Subject: [PATCH 1/9] Add LICENSE file --- LICENSE | 122 ++---------------------------------------------------- README.md | 2 +- 2 files changed, 5 insertions(+), 119 deletions(-) diff --git a/LICENSE b/LICENSE index 85219c8..7580d37 100644 --- a/LICENSE +++ b/LICENSE @@ -1,121 +1,7 @@ - -
-

Superhero-Search-Website

-
+## Copyright 2023, [Bhushan Deshmukh] -# 📗 Table of Contents +Permission is hereby granted, free of charge, to any person obtaining a copy of this [Portfolio] and associated documentation files, to deal in the [Portfolio] without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the [Portfolio], and to permit persons to whom the [Portfolio] is furnished to do so, subject to the following conditions: -- [📗 Table of Contents](#-table-of-contents) - - [🛠 Built With ](#-built-with-) - - [Tech Stack ](#tech-stack-) - - [Key Features ](#key-features-) - - [🚀 Live Demo ](#-live-demo-) - - [🚀 Project presentation ](#-project-presentation-) - - [💻 Getting Started ](#-getting-started-) - - [Prerequisites](#prerequisites) - - [👥 Authors ](#-authors-) - - [🔭 Future Features ](#-future-features-) - - [🤝 Contributing ](#-contributing-) - - [⭐️ Show your support ](#️-show-your-support-) - - [🙏 Acknowledgments ](#-acknowledgments-) - - [📝 License ](#-license-) +The above copyright notice and this permission notice shall be included in all copies or substantial portions of the [Portfolio]. - -**[A&B films]** shows list of popular Rockets
- -## 🛠 Built With - -### Tech Stack - - HTML - - CSS - - React - - Redux-toolkit - - WEBPACK - - Marvel-API - -### Key Features - -- When You Search you will see the searched results filtered . -- Used react-router to naviggate through pages. - -

(back to top)

- -## 🚀 Live Demo - -- [[Live Demo link](https://bhushan354.github.io/Superhero-Search-Project/)] - -

(back to top)

- -## 🚀 Project presentation - -- [Project presentation link](will add later) - -

(back to top)

- -## 💻 Getting Started - -To get a local copy up and running, follow these steps. - -### Prerequisites -- Browser -- Node -- Code Editor - -In order to run this project you need: - -To get a local copy up and running follow these simple example steps. - -- Choose a directory -- Open a Terminal -- write: git clone git@github.com:bhushan354/Superhero-Search-Project.git -- get into to directory -- write: npm install -- then write: npm start - -

(back to top)

- -## 👥 Authors - -👤 **Bhushan Deshmukh** -- GitHub: [@bhushan](https://github.com/bhushan354) -- Twitter: [@bhushan](https://twitter.com/Bhushan_4885) - - -

(back to top)

- - - -## 🔭 Future Features - -- [ ] **[Complete all the sections using different Api]** - -

(back to top)

- - -## 🤝 Contributing - -Contributions, issues, and feature requests are welcome! - -Feel free to check the [issues page](https://github.com/bhushan354//issues) - -

(back to top)

- - -## ⭐️ Show your support - -If you like this project, pplease, feel free to star the repository and share it with others who might benefit from it. - -

(back to top)

- -

(back to top)

- -## 🙏 Acknowledgments - -I would like to thank the Microverse team and Code reviewers who helped us create this project. Also, I would like to express our sincere gratitude to [Agustine Soria](https://github.com/SaveryIV) for his valuable assistance in solving a problem with fetching rockets From API. His expertise and guidance Ire instrumental in finding a solution. - - -## 📝 License - -This project is [MIT](./LICENSE) licensed. - -

(back to top)

+THE [Portfolio] IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE [Portfolio] OR THE USE OR OTHER DEALINGS IN THE [Portfolio]. \ No newline at end of file diff --git a/README.md b/README.md index baa9de6..b1e9f33 100644 --- a/README.md +++ b/README.md @@ -116,6 +116,6 @@ I would like to thank the Microverse team and Code reviewers who helped us creat ## 📝 License -This project is [MIT](./MIT) licensed. +This project is [MIT](./LICENSE) licensed.

(back to top)

From 04b23251bf3f27f70688b782a060f705ef23c5b3 Mon Sep 17 00:00:00 2001 From: bhushan354 Date: Sat, 14 Oct 2023 23:29:47 +0530 Subject: [PATCH 2/9] Use less than 2 warm colour --- src/App.css | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/App.css b/src/App.css index bbb21cd..383450d 100644 --- a/src/App.css +++ b/src/App.css @@ -5,7 +5,8 @@ } body { - background-color: darksalmon; + background: #010615; + color: #fff; } li { @@ -36,8 +37,9 @@ li { .listHome { height: 136px; - background: cornflowerblue; + background-color: hsl(242deg 88.4% 66.3% / 61%); border-radius: 6px; + color: #fff; } .homeSubInfo { @@ -48,7 +50,13 @@ li { .homeSubInfo h2 { text-decoration: none; font-size: medium; - color: rgb(65, 72, 84); + color: rgb(255, 255, 255); +} + +.homeSubInfo p { + text-decoration: none; + font-size: medium; + color: rgb(255, 255, 255); } .typeInput { @@ -83,7 +91,7 @@ secondpage styles */ } .individualHero { - background-color: brown; + background-color: hsl(242deg 88.4% 66.3% / 61%); border-radius: 6px; height: 100%; } @@ -97,7 +105,7 @@ secondpage styles */ .allHeroList img { width: 45vw; border-radius: 6px; - height: 60vh; + height: 24vh; object-fit: cover; margin-top: 2px; } @@ -126,23 +134,19 @@ secondpage styles */ width: 60%; } -.subInfo { - color: antiquewhite; - gap: 2px; - background-color: rgb(124, 109, 88); -} /* header styles */ .headerMain { display: flex; justify-content: space-between; padding: 10px; - background: cadetblue; + background: #010615; } svg { height: 80%; width: 38px; + color: #fff; } .setting { @@ -150,9 +154,7 @@ svg { } .headingTitle { - color: #433a3a; font-size: 34px; - background-color: bisque; padding: 4px; border-radius: 6px; } From 8e6e44ceb3d0f66ccf7fbe4afdf46fe76115c37d Mon Sep 17 00:00:00 2001 From: bhushan354 Date: Sat, 14 Oct 2023 23:34:01 +0530 Subject: [PATCH 3/9] Cretae new folder for test file --- .../__snapshots__/ComicHero.test.js.snap | 320 ----------------- .../{ => __test__}/ComicHero.test.js | 2 +- .../{ => __test__}/ComicList.test.js | 2 +- .../__snapshots__/ComicHero.test.js.snap | 321 ++++++++++++++++++ .../__snapshots__/ComicList.test.js.snap | 321 ++++++++++++++++++ 5 files changed, 644 insertions(+), 322 deletions(-) rename src/components/{ => __test__}/ComicHero.test.js (97%) rename src/components/{ => __test__}/ComicList.test.js (97%) create mode 100644 src/components/__test__/__snapshots__/ComicHero.test.js.snap create mode 100644 src/components/__test__/__snapshots__/ComicList.test.js.snap diff --git a/src/components/__snapshots__/ComicHero.test.js.snap b/src/components/__snapshots__/ComicHero.test.js.snap index 325aeb2..240c0c9 100644 --- a/src/components/__snapshots__/ComicHero.test.js.snap +++ b/src/components/__snapshots__/ComicHero.test.js.snap @@ -1,325 +1,5 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP -exports[`ComicHero component renders "Please Wait a Moment ..." when hero is not found 1`] = ` -Object { - "asFragment": [Function], - "baseElement": -
-

- Please Wait a Moment ... -

-
- , - "container":
-

- Please Wait a Moment ... -

-
, - "debug": [Function], - "findAllByAltText": [Function], - "findAllByDisplayValue": [Function], - "findAllByLabelText": [Function], - "findAllByPlaceholderText": [Function], - "findAllByRole": [Function], - "findAllByTestId": [Function], - "findAllByText": [Function], - "findAllByTitle": [Function], - "findByAltText": [Function], - "findByDisplayValue": [Function], - "findByLabelText": [Function], - "findByPlaceholderText": [Function], - "findByRole": [Function], - "findByTestId": [Function], - "findByText": [Function], - "findByTitle": [Function], - "getAllByAltText": [Function], - "getAllByDisplayValue": [Function], - "getAllByLabelText": [Function], - "getAllByPlaceholderText": [Function], - "getAllByRole": [Function], - "getAllByTestId": [Function], - "getAllByText": [Function], - "getAllByTitle": [Function], - "getByAltText": [Function], - "getByDisplayValue": [Function], - "getByLabelText": [Function], - "getByPlaceholderText": [Function], - "getByRole": [Function], - "getByTestId": [Function], - "getByText": [Function], - "getByTitle": [Function], - "queryAllByAltText": [Function], - "queryAllByDisplayValue": [Function], - "queryAllByLabelText": [Function], - "queryAllByPlaceholderText": [Function], - "queryAllByRole": [Function], - "queryAllByTestId": [Function], - "queryAllByText": [Function], - "queryAllByTitle": [Function], - "queryByAltText": [Function], - "queryByDisplayValue": [Function], - "queryByLabelText": [Function], - "queryByPlaceholderText": [Function], - "queryByRole": [Function], - "queryByTestId": [Function], - "queryByText": [Function], - "queryByTitle": [Function], - "rerender": [Function], - "unmount": [Function], -} -`; - -exports[`ComicHero component renders hero information when hero is found 1`] = ` -Object { - "asFragment": [Function], - "baseElement": -
-
- - - - - -

- Details -

- - - -
-
-
- Spider-Man -
-
-

- Name Of Hero: - Spider-Man -

-
-
-

- Comics: - 3 -

-
    -
  • - Comic 1 -
    • -
  • - Comic 2 -
    • -
  • - Comic 3 -
    • -
-

- More information: -

- - information - -

- Description: - The friendly neighborhood Spider-Man. -

-
-
-
-
-
- , - "container":
-
- - - - - -

- Details -

- - - -
-
-
- Spider-Man -
-
-

- Name Of Hero: - Spider-Man -

-
-
-

- Comics: - 3 -

-
    -
  • - Comic 1 -
    • -
  • - Comic 2 -
    • -
  • - Comic 3 -
    • -
-

- More information: -

- - information - -

- Description: - The friendly neighborhood Spider-Man. -

-
-
-
-
-
, - "debug": [Function], - "findAllByAltText": [Function], - "findAllByDisplayValue": [Function], - "findAllByLabelText": [Function], - "findAllByPlaceholderText": [Function], - "findAllByRole": [Function], - "findAllByTestId": [Function], - "findAllByText": [Function], - "findAllByTitle": [Function], - "findByAltText": [Function], - "findByDisplayValue": [Function], - "findByLabelText": [Function], - "findByPlaceholderText": [Function], - "findByRole": [Function], - "findByTestId": [Function], - "findByText": [Function], - "findByTitle": [Function], - "getAllByAltText": [Function], - "getAllByDisplayValue": [Function], - "getAllByLabelText": [Function], - "getAllByPlaceholderText": [Function], - "getAllByRole": [Function], - "getAllByTestId": [Function], - "getAllByText": [Function], - "getAllByTitle": [Function], - "getByAltText": [Function], - "getByDisplayValue": [Function], - "getByLabelText": [Function], - "getByPlaceholderText": [Function], - "getByRole": [Function], - "getByTestId": [Function], - "getByText": [Function], - "getByTitle": [Function], - "queryAllByAltText": [Function], - "queryAllByDisplayValue": [Function], - "queryAllByLabelText": [Function], - "queryAllByPlaceholderText": [Function], - "queryAllByRole": [Function], - "queryAllByTestId": [Function], - "queryAllByText": [Function], - "queryAllByTitle": [Function], - "queryByAltText": [Function], - "queryByDisplayValue": [Function], - "queryByLabelText": [Function], - "queryByPlaceholderText": [Function], - "queryByRole": [Function], - "queryByTestId": [Function], - "queryByText": [Function], - "queryByTitle": [Function], - "rerender": [Function], - "unmount": [Function], -} -`; - exports[`Testing ComicHero Component renders "Please Wait a Moment ..." when hero is not found 1`] = ` Object { "asFragment": [Function], diff --git a/src/components/ComicHero.test.js b/src/components/__test__/ComicHero.test.js similarity index 97% rename from src/components/ComicHero.test.js rename to src/components/__test__/ComicHero.test.js index c172a14..4d4ea69 100644 --- a/src/components/ComicHero.test.js +++ b/src/components/__test__/ComicHero.test.js @@ -3,7 +3,7 @@ import { render } from '@testing-library/react'; import configureMockStore from 'redux-mock-store'; import { Provider } from 'react-redux'; import { MemoryRouter, Routes, Route } from 'react-router-dom'; -import ComicHero from './ComicHero'; +import ComicHero from '../ComicHero'; const mockStore = configureMockStore([]); diff --git a/src/components/ComicList.test.js b/src/components/__test__/ComicList.test.js similarity index 97% rename from src/components/ComicList.test.js rename to src/components/__test__/ComicList.test.js index c172a14..4d4ea69 100644 --- a/src/components/ComicList.test.js +++ b/src/components/__test__/ComicList.test.js @@ -3,7 +3,7 @@ import { render } from '@testing-library/react'; import configureMockStore from 'redux-mock-store'; import { Provider } from 'react-redux'; import { MemoryRouter, Routes, Route } from 'react-router-dom'; -import ComicHero from './ComicHero'; +import ComicHero from '../ComicHero'; const mockStore = configureMockStore([]); diff --git a/src/components/__test__/__snapshots__/ComicHero.test.js.snap b/src/components/__test__/__snapshots__/ComicHero.test.js.snap new file mode 100644 index 0000000..240c0c9 --- /dev/null +++ b/src/components/__test__/__snapshots__/ComicHero.test.js.snap @@ -0,0 +1,321 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`Testing ComicHero Component renders "Please Wait a Moment ..." when hero is not found 1`] = ` +Object { + "asFragment": [Function], + "baseElement": +
+

+ Please Wait a Moment ... +

+
+ , + "container":
+

+ Please Wait a Moment ... +

+
, + "debug": [Function], + "findAllByAltText": [Function], + "findAllByDisplayValue": [Function], + "findAllByLabelText": [Function], + "findAllByPlaceholderText": [Function], + "findAllByRole": [Function], + "findAllByTestId": [Function], + "findAllByText": [Function], + "findAllByTitle": [Function], + "findByAltText": [Function], + "findByDisplayValue": [Function], + "findByLabelText": [Function], + "findByPlaceholderText": [Function], + "findByRole": [Function], + "findByTestId": [Function], + "findByText": [Function], + "findByTitle": [Function], + "getAllByAltText": [Function], + "getAllByDisplayValue": [Function], + "getAllByLabelText": [Function], + "getAllByPlaceholderText": [Function], + "getAllByRole": [Function], + "getAllByTestId": [Function], + "getAllByText": [Function], + "getAllByTitle": [Function], + "getByAltText": [Function], + "getByDisplayValue": [Function], + "getByLabelText": [Function], + "getByPlaceholderText": [Function], + "getByRole": [Function], + "getByTestId": [Function], + "getByText": [Function], + "getByTitle": [Function], + "queryAllByAltText": [Function], + "queryAllByDisplayValue": [Function], + "queryAllByLabelText": [Function], + "queryAllByPlaceholderText": [Function], + "queryAllByRole": [Function], + "queryAllByTestId": [Function], + "queryAllByText": [Function], + "queryAllByTitle": [Function], + "queryByAltText": [Function], + "queryByDisplayValue": [Function], + "queryByLabelText": [Function], + "queryByPlaceholderText": [Function], + "queryByRole": [Function], + "queryByTestId": [Function], + "queryByText": [Function], + "queryByTitle": [Function], + "rerender": [Function], + "unmount": [Function], +} +`; + +exports[`Testing ComicHero Component renders hero information when hero is found 1`] = ` +Object { + "asFragment": [Function], + "baseElement": +
+
+ + + + + +

+ Details +

+ + + +
+
+
+ Spider-Man +
+
+

+ Name Of Hero: + Spider-Man +

+
+
+

+ Comics: + 3 +

+
    +
  • + Comic 1 +
    • +
  • + Comic 2 +
    • +
  • + Comic 3 +
    • +
+

+ More information: +

+ + information + +

+ Description: + The friendly neighborhood Spider-Man. +

+
+
+
+
+
+ , + "container":
+
+ + + + + +

+ Details +

+ + + +
+
+
+ Spider-Man +
+
+

+ Name Of Hero: + Spider-Man +

+
+
+

+ Comics: + 3 +

+
    +
  • + Comic 1 +
    • +
  • + Comic 2 +
    • +
  • + Comic 3 +
    • +
+

+ More information: +

+ + information + +

+ Description: + The friendly neighborhood Spider-Man. +

+
+
+
+
+
, + "debug": [Function], + "findAllByAltText": [Function], + "findAllByDisplayValue": [Function], + "findAllByLabelText": [Function], + "findAllByPlaceholderText": [Function], + "findAllByRole": [Function], + "findAllByTestId": [Function], + "findAllByText": [Function], + "findAllByTitle": [Function], + "findByAltText": [Function], + "findByDisplayValue": [Function], + "findByLabelText": [Function], + "findByPlaceholderText": [Function], + "findByRole": [Function], + "findByTestId": [Function], + "findByText": [Function], + "findByTitle": [Function], + "getAllByAltText": [Function], + "getAllByDisplayValue": [Function], + "getAllByLabelText": [Function], + "getAllByPlaceholderText": [Function], + "getAllByRole": [Function], + "getAllByTestId": [Function], + "getAllByText": [Function], + "getAllByTitle": [Function], + "getByAltText": [Function], + "getByDisplayValue": [Function], + "getByLabelText": [Function], + "getByPlaceholderText": [Function], + "getByRole": [Function], + "getByTestId": [Function], + "getByText": [Function], + "getByTitle": [Function], + "queryAllByAltText": [Function], + "queryAllByDisplayValue": [Function], + "queryAllByLabelText": [Function], + "queryAllByPlaceholderText": [Function], + "queryAllByRole": [Function], + "queryAllByTestId": [Function], + "queryAllByText": [Function], + "queryAllByTitle": [Function], + "queryByAltText": [Function], + "queryByDisplayValue": [Function], + "queryByLabelText": [Function], + "queryByPlaceholderText": [Function], + "queryByRole": [Function], + "queryByTestId": [Function], + "queryByText": [Function], + "queryByTitle": [Function], + "rerender": [Function], + "unmount": [Function], +} +`; diff --git a/src/components/__test__/__snapshots__/ComicList.test.js.snap b/src/components/__test__/__snapshots__/ComicList.test.js.snap new file mode 100644 index 0000000..240c0c9 --- /dev/null +++ b/src/components/__test__/__snapshots__/ComicList.test.js.snap @@ -0,0 +1,321 @@ +// Jest Snapshot v1, https://goo.gl/fbAQLP + +exports[`Testing ComicHero Component renders "Please Wait a Moment ..." when hero is not found 1`] = ` +Object { + "asFragment": [Function], + "baseElement": +
+

+ Please Wait a Moment ... +

+
+ , + "container":
+

+ Please Wait a Moment ... +

+
, + "debug": [Function], + "findAllByAltText": [Function], + "findAllByDisplayValue": [Function], + "findAllByLabelText": [Function], + "findAllByPlaceholderText": [Function], + "findAllByRole": [Function], + "findAllByTestId": [Function], + "findAllByText": [Function], + "findAllByTitle": [Function], + "findByAltText": [Function], + "findByDisplayValue": [Function], + "findByLabelText": [Function], + "findByPlaceholderText": [Function], + "findByRole": [Function], + "findByTestId": [Function], + "findByText": [Function], + "findByTitle": [Function], + "getAllByAltText": [Function], + "getAllByDisplayValue": [Function], + "getAllByLabelText": [Function], + "getAllByPlaceholderText": [Function], + "getAllByRole": [Function], + "getAllByTestId": [Function], + "getAllByText": [Function], + "getAllByTitle": [Function], + "getByAltText": [Function], + "getByDisplayValue": [Function], + "getByLabelText": [Function], + "getByPlaceholderText": [Function], + "getByRole": [Function], + "getByTestId": [Function], + "getByText": [Function], + "getByTitle": [Function], + "queryAllByAltText": [Function], + "queryAllByDisplayValue": [Function], + "queryAllByLabelText": [Function], + "queryAllByPlaceholderText": [Function], + "queryAllByRole": [Function], + "queryAllByTestId": [Function], + "queryAllByText": [Function], + "queryAllByTitle": [Function], + "queryByAltText": [Function], + "queryByDisplayValue": [Function], + "queryByLabelText": [Function], + "queryByPlaceholderText": [Function], + "queryByRole": [Function], + "queryByTestId": [Function], + "queryByText": [Function], + "queryByTitle": [Function], + "rerender": [Function], + "unmount": [Function], +} +`; + +exports[`Testing ComicHero Component renders hero information when hero is found 1`] = ` +Object { + "asFragment": [Function], + "baseElement": +
+
+ + + + + +

+ Details +

+ + + +
+
+
+ Spider-Man +
+
+

+ Name Of Hero: + Spider-Man +

+
+
+

+ Comics: + 3 +

+
    +
  • + Comic 1 +
    • +
  • + Comic 2 +
    • +
  • + Comic 3 +
    • +
+

+ More information: +

+ + information + +

+ Description: + The friendly neighborhood Spider-Man. +

+
+
+
+
+
+ , + "container":
+
+ + + + + +

+ Details +

+ + + +
+
+
+ Spider-Man +
+
+

+ Name Of Hero: + Spider-Man +

+
+
+

+ Comics: + 3 +

+
    +
  • + Comic 1 +
    • +
  • + Comic 2 +
    • +
  • + Comic 3 +
    • +
+

+ More information: +

+ + information + +

+ Description: + The friendly neighborhood Spider-Man. +

+
+
+
+
+
, + "debug": [Function], + "findAllByAltText": [Function], + "findAllByDisplayValue": [Function], + "findAllByLabelText": [Function], + "findAllByPlaceholderText": [Function], + "findAllByRole": [Function], + "findAllByTestId": [Function], + "findAllByText": [Function], + "findAllByTitle": [Function], + "findByAltText": [Function], + "findByDisplayValue": [Function], + "findByLabelText": [Function], + "findByPlaceholderText": [Function], + "findByRole": [Function], + "findByTestId": [Function], + "findByText": [Function], + "findByTitle": [Function], + "getAllByAltText": [Function], + "getAllByDisplayValue": [Function], + "getAllByLabelText": [Function], + "getAllByPlaceholderText": [Function], + "getAllByRole": [Function], + "getAllByTestId": [Function], + "getAllByText": [Function], + "getAllByTitle": [Function], + "getByAltText": [Function], + "getByDisplayValue": [Function], + "getByLabelText": [Function], + "getByPlaceholderText": [Function], + "getByRole": [Function], + "getByTestId": [Function], + "getByText": [Function], + "getByTitle": [Function], + "queryAllByAltText": [Function], + "queryAllByDisplayValue": [Function], + "queryAllByLabelText": [Function], + "queryAllByPlaceholderText": [Function], + "queryAllByRole": [Function], + "queryAllByTestId": [Function], + "queryAllByText": [Function], + "queryAllByTitle": [Function], + "queryByAltText": [Function], + "queryByDisplayValue": [Function], + "queryByLabelText": [Function], + "queryByPlaceholderText": [Function], + "queryByRole": [Function], + "queryByTestId": [Function], + "queryByText": [Function], + "queryByTitle": [Function], + "rerender": [Function], + "unmount": [Function], +} +`; From 109d995fe1d0a01a1cb2c54d025d9eda77b42afc Mon Sep 17 00:00:00 2001 From: bhushan354 Date: Sat, 14 Oct 2023 23:41:09 +0530 Subject: [PATCH 4/9] Readme file changes , linters fix --- README.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index b1e9f33..7cb3266 100644 --- a/README.md +++ b/README.md @@ -21,8 +21,6 @@ - [📝 License ](#-license-) -**[A&B films]** shows list of popular Rockets
- ## 🛠 Built With ### Tech Stack @@ -96,7 +94,7 @@ To get a local copy up and running follow these simple example steps. Contributions, issues, and feature requests are welcome! -Feel free to check the [issues page](https://github.com/bhushan354//issues) +Feel free to check the [issues page](https://github.com/bhushan354/Superhero-Search-Project/issues)

(back to top)

@@ -111,7 +109,7 @@ If you like this project, pplease, feel free to star the repository and share it ## 🙏 Acknowledgments -I would like to thank the Microverse team and Code reviewers who helped us create this project. Also, I would like to express our sincere gratitude to [Agustine Soria](https://github.com/SaveryIV) for his valuable assistance in solving a problem with fetching Superheor data From API. His expertise and guidance helped me in finding a solution. +I would like to thank the Nelson Sakwa from him I took Inspiration to build this project and Microverse team and Code reviewers who helped us create this project. Also, I would like to express our sincere gratitude to [Agustine Soria](https://github.com/SaveryIV) for his valuable assistance in solving a problem with fetching Superheor data From API. His expertise and guidance helped me in finding a solution. ## 📝 License From fa97ba7da80cc9e06c8d4103662f23a778bebb73 Mon Sep 17 00:00:00 2001 From: bhushan354 Date: Sat, 14 Oct 2023 23:49:32 +0530 Subject: [PATCH 5/9] linters fix --- src/App.css | 1 - 1 file changed, 1 deletion(-) diff --git a/src/App.css b/src/App.css index 383450d..275c615 100644 --- a/src/App.css +++ b/src/App.css @@ -134,7 +134,6 @@ secondpage styles */ width: 60%; } - /* header styles */ .headerMain { display: flex; From 7f659ff96195d1198e8d5e64898f36c28fe7e40c Mon Sep 17 00:00:00 2001 From: bhushan354 Date: Sun, 15 Oct 2023 00:39:10 +0530 Subject: [PATCH 6/9] Deployment changes --- package-lock.json | 160 ++++++++++++++++++++++++++++++++++++ package.json | 1 + src/components/ComicHero.js | 4 +- 3 files changed, 163 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 2d933b3..b625be9 100644 --- a/package-lock.json +++ b/package-lock.json @@ -35,6 +35,7 @@ "eslint-plugin-jsx-a11y": "^6.7.1", "eslint-plugin-react": "^7.33.2", "eslint-plugin-react-hooks": "^4.6.0", + "gh-pages": "^6.0.0", "redux-mock-store": "^1.5.4", "stylelint": "^13.13.1", "stylelint-config-standard": "^21.0.0", @@ -5229,6 +5230,15 @@ "node": ">=8" } }, + "node_modules/array-uniq": { + "version": "1.0.3", + "resolved": "https://registry.npmjs.org/array-uniq/-/array-uniq-1.0.3.tgz", + "integrity": "sha512-MNha4BWQ6JbwhFhj03YK552f7cb3AzoE8SzeljgChvL1dl3IcvggXVz1DilzySZkCja+CXuZbdW7yATchWn8/Q==", + "dev": true, + "engines": { + "node": ">=0.10.0" + } + }, "node_modules/array.prototype.findlastindex": { "version": "1.2.3", "resolved": "https://registry.npmjs.org/array.prototype.findlastindex/-/array.prototype.findlastindex-1.2.3.tgz", @@ -7335,6 +7345,12 @@ "resolved": "https://registry.npmjs.org/electron-to-chromium/-/electron-to-chromium-1.4.551.tgz", "integrity": "sha512-/Ng/W/kFv7wdEHYzxdK7Cv0BHEGSkSB3M0Ssl8Ndr1eMiYeas/+Mv4cNaDqamqWx6nd2uQZfPz6g25z25M/sdw==" }, + "node_modules/email-addresses": { + "version": "5.0.0", + "resolved": "https://registry.npmjs.org/email-addresses/-/email-addresses-5.0.0.tgz", + "integrity": "sha512-4OIPYlA6JXqtVn8zpHpGiI7vE6EQOAg16aGnDMIAlZVinnoZ8208tW1hAbjWydgN/4PLTT9q+O1K6AH/vALJGw==", + "dev": true + }, "node_modules/emittery": { "version": "0.8.1", "resolved": "https://registry.npmjs.org/emittery/-/emittery-0.8.1.tgz", @@ -8606,6 +8622,32 @@ "node": ">=10" } }, + "node_modules/filename-reserved-regex": { + "version": "2.0.0", + "resolved": "https://registry.npmjs.org/filename-reserved-regex/-/filename-reserved-regex-2.0.0.tgz", + "integrity": "sha512-lc1bnsSr4L4Bdif8Xb/qrtokGbq5zlsms/CYH8PP+WtCkGNF65DPiQY8vG3SakEdRn8Dlnm+gW/qWKKjS5sZzQ==", + "dev": true, + "engines": { + "node": ">=4" + } + }, + "node_modules/filenamify": { + "version": "4.3.0", + "resolved": "https://registry.npmjs.org/filenamify/-/filenamify-4.3.0.tgz", + "integrity": "sha512-hcFKyUG57yWGAzu1CMt/dPzYZuv+jAJUT85bL8mrXvNe6hWj6yEHEc4EdcgiA6Z3oi1/9wXJdZPXF2dZNgwgOg==", + "dev": true, + "dependencies": { + "filename-reserved-regex": "^2.0.0", + "strip-outer": "^1.0.1", + "trim-repeated": "^1.0.0" + }, + "engines": { + "node": ">=8" + }, + "funding": { + "url": "https://github.com/sponsors/sindresorhus" + } + }, "node_modules/filesize": { "version": "8.0.7", "resolved": "https://registry.npmjs.org/filesize/-/filesize-8.0.7.tgz", @@ -9085,6 +9127,79 @@ "url": "https://github.com/sponsors/ljharb" } }, + "node_modules/gh-pages": { + "version": "6.0.0", + "resolved": "https://registry.npmjs.org/gh-pages/-/gh-pages-6.0.0.tgz", + "integrity": "sha512-FXZWJRsvP/fK2HJGY+Di6FRNHvqFF6gOIELaopDjXXgjeOYSNURcuYwEO/6bwuq6koP5Lnkvnr5GViXzuOB89g==", + "dev": true, + "dependencies": { + "async": "^3.2.4", + "commander": "^11.0.0", + "email-addresses": "^5.0.0", + "filenamify": "^4.3.0", + "find-cache-dir": "^3.3.1", + "fs-extra": "^11.1.1", + "globby": "^6.1.0" + }, + "bin": { + "gh-pages": "bin/gh-pages.js", + "gh-pages-clean": "bin/gh-pages-clean.js" + }, + "engines": { + "node": ">=10" + } + }, + "node_modules/gh-pages/node_modules/array-union": { + "version": "1.0.2", + "resolved": "https://registry.npmjs.org/array-union/-/array-union-1.0.2.tgz", + "integrity": "sha512-Dxr6QJj/RdU/hCaBjOfxW+q6lyuVE6JFWIrAUpuOOhoJJoQ99cUn3igRaHVB5P9WrgFVN0FfArM3x0cueOU8ng==", + "dev": true, + "dependencies": { + "array-uniq": "^1.0.1" + }, + "engines": { + "node": ">=0.10.0" + } + }, + "node_modules/gh-pages/node_modules/commander": { + "version": "11.1.0", + "resolved": "https://registry.npmjs.org/commander/-/commander-11.1.0.tgz", + "integrity": "sha512-yPVavfyCcRhmorC7rWlkHn15b4wDVgVmBA7kV4QVBsF7kv/9TKJAbAXVTxvTnwP8HHKjRCJDClKbciiYS7p0DQ==", + "dev": true, + "engines": { + "node": ">=16" + } + }, + "node_modules/gh-pages/node_modules/fs-extra": { + "version": "11.1.1", + "resolved": "https://registry.npmjs.org/fs-extra/-/fs-extra-11.1.1.tgz", + "integrity": "sha512-MGIE4HOvQCeUCzmlHs0vXpih4ysz4wg9qiSAu6cd42lVwPbTM1TjV7RusoyQqMmk/95gdQZX72u+YW+c3eEpFQ==", + "dev": true, + "dependencies": { + "graceful-fs": "^4.2.0", + "jsonfile": "^6.0.1", + "universalify": "^2.0.0" + }, + "engines": { + "node": ">=14.14" + } + }, + "node_modules/gh-pages/node_modules/globby": { + "version": "6.1.0", + "resolved": "https://registry.npmjs.org/globby/-/globby-6.1.0.tgz", + "integrity": "sha512-KVbFv2TQtbzCoxAnfD6JcHZTYCzyliEaaeM/gH8qQdkKr5s0OP9scEgvdcngyk7AVdY6YVW/TJHd+lQ/Df3Daw==", + "dev": true, + "dependencies": { + "array-union": "^1.0.1", + "glob": "^7.0.3", + "object-assign": "^4.0.1", + "pify": "^2.0.0", + "pinkie-promise": "^2.0.0" + }, + "engines": { + "node": ">=0.10.0" + } + }, "node_modules/glob": { "version": "7.2.3", "resolved": "https://registry.npmjs.org/glob/-/glob-7.2.3.tgz", @@ -13860,6 +13975,27 @@ "node": ">=0.10.0" } }, + "node_modules/pinkie": { + "version": "2.0.4", + "resolved": "https://registry.npmjs.org/pinkie/-/pinkie-2.0.4.tgz", + "integrity": "sha512-MnUuEycAemtSaeFSjXKW/aroV7akBbY+Sv+RkyqFjgAe73F+MR0TBWKBRDkmfWq/HiFmdavfZ1G7h4SPZXaCSg==", + "dev": true, + "engines": { + "node": ">=0.10.0" + } + }, + "node_modules/pinkie-promise": { + "version": "2.0.1", + "resolved": "https://registry.npmjs.org/pinkie-promise/-/pinkie-promise-2.0.1.tgz", + "integrity": "sha512-0Gni6D4UcLTbv9c57DfxDGdr41XfgUjqWZu492f0cIGr16zDU06BWP/RAEvOuo7CQ0CNjHaLlM59YJJFm3NWlw==", + "dev": true, + "dependencies": { + "pinkie": "^2.0.0" + }, + "engines": { + "node": ">=0.10.0" + } + }, "node_modules/pirates": { "version": "4.0.6", "resolved": "https://registry.npmjs.org/pirates/-/pirates-4.0.6.tgz", @@ -17867,6 +18003,18 @@ "url": "https://github.com/sponsors/sindresorhus" } }, + "node_modules/strip-outer": { + "version": "1.0.1", + "resolved": "https://registry.npmjs.org/strip-outer/-/strip-outer-1.0.1.tgz", + "integrity": "sha512-k55yxKHwaXnpYGsOzg4Vl8+tDrWylxDEpknGjhTiZB8dFRU5rTo9CAzeycivxV3s+zlTKwrs6WxMxR95n26kwg==", + "dev": true, + "dependencies": { + "escape-string-regexp": "^1.0.2" + }, + "engines": { + "node": ">=0.10.0" + } + }, "node_modules/style-loader": { "version": "3.3.3", "resolved": "https://registry.npmjs.org/style-loader/-/style-loader-3.3.3.tgz", @@ -18726,6 +18874,18 @@ "node": ">=8" } }, + "node_modules/trim-repeated": { + "version": "1.0.0", + "resolved": "https://registry.npmjs.org/trim-repeated/-/trim-repeated-1.0.0.tgz", + "integrity": "sha512-pkonvlKk8/ZuR0D5tLW8ljt5I8kmxp2XKymhepUeOdCEfKpZaktSArkLHZt76OB1ZvO9bssUsDty4SWhLvZpLg==", + "dev": true, + "dependencies": { + "escape-string-regexp": "^1.0.2" + }, + "engines": { + "node": ">=0.10.0" + } + }, "node_modules/trough": { "version": "1.0.5", "resolved": "https://registry.npmjs.org/trough/-/trough-1.0.5.tgz", diff --git a/package.json b/package.json index c1d097e..e0dd5c3 100644 --- a/package.json +++ b/package.json @@ -54,6 +54,7 @@ "eslint-plugin-jsx-a11y": "^6.7.1", "eslint-plugin-react": "^7.33.2", "eslint-plugin-react-hooks": "^4.6.0", + "gh-pages": "^6.0.0", "redux-mock-store": "^1.5.4", "stylelint": "^13.13.1", "stylelint-config-standard": "^21.0.0", diff --git a/src/components/ComicHero.js b/src/components/ComicHero.js index 34cd0ce..f74418e 100644 --- a/src/components/ComicHero.js +++ b/src/components/ComicHero.js @@ -41,8 +41,8 @@ function ComicHero() { {selHero.comics.available}
    - {selHero.comics.items.map((comic) => ( -
  • {comic.name}
    • + {selHero.comics.items.map((comic, index) => ( +
  • {comic.name}
    • ))}
From 6468cdb4074c35cc6dcdbedad799971923efc84d Mon Sep 17 00:00:00 2001 From: bhushan354 Date: Sun, 15 Oct 2023 01:17:49 +0530 Subject: [PATCH 7/9] changes --- package-lock.json | 19 +++++++++++++++++++ package.json | 4 ++++ 2 files changed, 23 insertions(+) diff --git a/package-lock.json b/package-lock.json index b625be9..6c93e58 100644 --- a/package-lock.json +++ b/package-lock.json @@ -29,6 +29,7 @@ "@babel/eslint-parser": "^7.22.15", "@babel/plugin-syntax-jsx": "^7.22.5", "@babel/preset-react": "^7.22.15", + "cross-env": "^7.0.3", "eslint": "^7.32.0", "eslint-config-airbnb": "^18.2.1", "eslint-plugin-import": "^2.28.1", @@ -6497,6 +6498,24 @@ "node": ">=10" } }, + "node_modules/cross-env": { + "version": "7.0.3", + "resolved": "https://registry.npmjs.org/cross-env/-/cross-env-7.0.3.tgz", + "integrity": "sha512-+/HKd6EgcQCJGh2PSjZuUitQBQynKor4wrFbRg4DtAgS1aWO+gU52xpH7M9ScGgXSYmAVS9bIJ8EzuaGw0oNAw==", + "dev": true, + "dependencies": { + "cross-spawn": "^7.0.1" + }, + "bin": { + "cross-env": "src/bin/cross-env.js", + "cross-env-shell": "src/bin/cross-env-shell.js" + }, + "engines": { + "node": ">=10.14", + "npm": ">=6", + "yarn": ">=1" + } + }, "node_modules/cross-spawn": { "version": "7.0.3", "resolved": "https://registry.npmjs.org/cross-spawn/-/cross-spawn-7.0.3.tgz", diff --git a/package.json b/package.json index e0dd5c3..b30dc03 100644 --- a/package.json +++ b/package.json @@ -1,4 +1,5 @@ { + "homepage": "https://bhushan354.github.io/Superhero-Search-Project", "name": "superhero-search-project", "version": "0.1.0", "private": true, @@ -21,6 +22,8 @@ }, "scripts": { "start": "react-scripts start", + "predeploy": "npm run build", + "deploy": "gh-pages -d build", "build": "react-scripts build", "test": "react-scripts test", "eject": "react-scripts eject" @@ -48,6 +51,7 @@ "@babel/eslint-parser": "^7.22.15", "@babel/plugin-syntax-jsx": "^7.22.5", "@babel/preset-react": "^7.22.15", + "cross-env": "^7.0.3", "eslint": "^7.32.0", "eslint-config-airbnb": "^18.2.1", "eslint-plugin-import": "^2.28.1", From 6551729b5c0ad18256adf9334b67a126a335e1bf Mon Sep 17 00:00:00 2001 From: bhushan354 Date: Sun, 15 Oct 2023 01:24:00 +0530 Subject: [PATCH 8/9] Add presentaation video --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 7cb3266..e7c7a2a 100644 --- a/README.md +++ b/README.md @@ -46,7 +46,7 @@ ## 🚀 Project presentation -- [Project presentation link](will add later) +- [Project presentation link](https://drive.google.com/file/d/1DLrnDYy-_wef153-CCEMP3wsz0uk5aqB/view?usp=sharing)

(back to top)

From e3eb9bac7c5991a02edd61bb6c9aaaedc6157d35 Mon Sep 17 00:00:00 2001 From: bhushan354 Date: Sun, 15 Oct 2023 01:41:06 +0530 Subject: [PATCH 9/9] changes --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index b30dc03..afcaba1 100644 --- a/package.json +++ b/package.json @@ -23,6 +23,7 @@ "scripts": { "start": "react-scripts start", "predeploy": "npm run build", + "dist": "cross-env NODE_ENV=production npm run build", "deploy": "gh-pages -d build", "build": "react-scripts build", "test": "react-scripts test",