-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow extension for the README file #972
Comments
This would be a welcome addition and might encourage annotators to write a better |
I agree that these are good arguments to allow |
This also came up before https://github.com/bids-standard/bids-validator/pull/1281#discussion_r630118909 @effigies comment from back then shows that he'd also be in favor of supporting this (with a small caveat):
|
Thanks for finding it.
I wouldn't go a far as limiting and verifying Markdown flavors. I think it is just about the file extension. As per specification, And if you would like to limit the Markdown flavor, I propose something standard, like CommonMark, since both GitHub and GitLab flavors are its supersets. |
We decided to deal with this after the 1.7.0 release. I think most of us agree that allowing common extensions will be fine, and we just need to decide on the subset of extensions and then implement it in the spec, examples, and validator. I am personally in favor of permitting TXT, MD, RST - because all of these can be read reasonably well in a text document even without any rendering. |
I'm happy to help and I have time to commit. |
Good to hear! I think you could start to open PRs then, and we can iterate there. |
@mateuszpawlik -- just a short reminder that I think your proposal is worthwhile implementing. Let me know if you ran out of time and want me /someone else to do it instead. |
I'm sorry but I didn't have a long enough stretch to figure out where to start and where exactly the changes should be implemented. I still would like to do it because it's a nice, simple enough exercise to understand the ecosystem. Maybe there are some contribution details that list the things to change? If not, I'll start making a list tomorrow. Would that work? |
These are two important documents to read:
As for making the changes, that'd be in the specification text - probably somewhere here:
For the validator, you could open an issue on https://github.com/bids-standard/bids-validator/ and we can try to see where to put the check there. I wouldn't know that off the top of my head |
I've started working but failed already while building #1030 . |
GitLab, and it seems that also GitHub, cannot render markdown if the file doesn't have an extension. Currently, BIDS Validator complains that there is no
README
file althoughREADME.md
is there. I think this is due to the following rule:https://github.com/bids-standard/bids-specification/blob/febae4fb9b2c9f055dc1392e0283c85f05618de0/src/schema/rules/top_level_files.yaml#L2:L5
Could we change that and support file extensions for the
README
file? I know it would require a few changes in the documentation and maybe the validator but if we could work out the list, I'm willing to work on it.The text was updated successfully, but these errors were encountered: