Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ChatInput Component #644

Closed
1 task
paulsojan opened this issue Mar 21, 2024 · 3 comments · Fixed by #658
Closed
1 task

Refactor ChatInput Component #644

paulsojan opened this issue Mar 21, 2024 · 3 comments · Fixed by #658
Assignees
@shashank-bhatotia
Labels
1.5D Estimate - 12 hours PR The issue has a PR associated with it. refactoring Code changes, better way to organize code etc.

Comments

@paulsojan
Copy link
Contributor

paulsojan commented Mar 21, 2024 •
edited
Loading

  • Fix UI inconsistencies while showing the cc/bb field with attachments.
@paulsojan paulsojan self-assigned this Mar 21, 2024
@paulsojan paulsojan added the refactoring Code changes, better way to organize code etc. label Mar 21, 2024
@paulsojan paulsojan added the 1.5D Estimate - 12 hours label Apr 15, 2024
@shashank-bhatotia
Copy link
Contributor

@paulsojan: Will it be possible for you to share a few screenshots describing the UI inconsistencies? Or maybe a short neetoRecord video?

@paulsojan
Copy link
Contributor Author

@shashank-bhatotia https://github.com/bigbinary/neeto-ui-rn/assets/47073691/e727f568-04e8-4473-b873-9d78416f2803

@shashank-bhatotia
Copy link
Contributor

@paulsojan The expanded state (which shows the email fields) persist even after uploading the attachment. The expansion and contraction is now dependent solely on user's action by tapping the minimise/maximise icon:

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-30.at.10.49.48.mp4

@neetogit-bot neetogit-bot bot added the working A branch associated with this issue is created. label May 30, 2024
@shashank-bhatotia shashank-bhatotia mentioned this issue May 30, 2024
Merged
@neetogit-bot neetogit-bot bot added the PR The issue has a PR associated with it. label May 30, 2024
@neetogit-bot neetogit-bot bot removed the working A branch associated with this issue is created. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shashank-bhatotia shashank-bhatotia

Labels
1.5D Estimate - 12 hours PR The issue has a PR associated with it. refactoring Code changes, better way to organize code etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor ChatInput component bigbinary/neeto-ui-rn
2 participants
@paulsojan @shashank-bhatotia