Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIANN output with Triqler search engine score #188

Closed
ypriverol opened this issue May 22, 2022 · 4 comments · Fixed by #186
Closed

DIANN output with Triqler search engine score #188

ypriverol opened this issue May 22, 2022 · 4 comments · Fixed by #186
Assignees
Labels
enhancement New feature or request

Comments

@ypriverol
Copy link
Member

Description of feature

@qinchunyuan I'm reviwing some of the DIANN Triqler outputs and I have observed that for some peptides the score is 0.0, Example:

proteins	peptide	charge	intensity	run	condition	searchScore
RL4_HUMAN	AAAAAAALQAK	2	21465.4	N294-2	lung	0.0
RL4_HUMAN	AAAAAAALQAK	2	31655.7	N295-1	lung	0.0

How are you getting those scores? Are those q-values? or probabilities?

@ypriverol ypriverol added the enhancement New feature or request label May 22, 2022
@daichengxin
Copy link
Collaborator

Previously 1 - PEP. Now updated to searchScore= -np.log(Q.value)

@ypriverol
Copy link
Member Author

ypriverol commented May 22, 2022

For all DDA and DIA.? @timosachsenberg uses 1-qvalue when exporting triqler in PLFQ. Why we are doing log.

We should get there as much consistency as possible.

@jpfeuffer
Copy link
Collaborator

No, we are using 1-PEP. Probably Diann does not have probabilities, so they needed to come up with a hack. We should follow their hack for now.
A triqler input of 0 (probability) means q-value of 1, which is fine. It won't really work for good scores, which can have scores higher than 1 now. But maybe triqler can handle this? Or they have another additional transformation after that?

@ypriverol ypriverol linked a pull request May 23, 2022 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants