Fix 34 - GridDividerItemDecoration item offsets do not space columns correctly #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a fixed width of the grid, the horizontal offset of each columns need to be calculated proportionately to its position. Resolves: bignerdranch#34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34
The current library only supports vertical orientation which means that we can expand the grid vertically if required. So vertical offset calculation is simple, merely moving items down.
The current horizontal spacing method does the same as the vertical method, and ends up pushing items off the grid to the right (this is easiest seen with a wide divider, say
32dp). This is because there is only a fixed horizontal width available that needs to contain the items and the dividers.This PR calculates the amount of offset for each column to make sure that they are all evenly spaced across the width of the grid.
I hope you do not mind adding the comment there - I spent quite a long time trying to figure out the purpose of some of the variables and I hope this comment helps future maintainers.
As with all contributions to foreign repos, I'm happy to change the styling to be consistent with your team so let me know what I should change.