RPM installation is not creating needed Linux user/group "ntfy"

[cmeis]

The installation via RPM doesn't create the user/group "ntfy" referenced in the systemd service config file. Tested using current version 1.11.2.
This leads to the service not starting:

Jan 04 12:59:41 localhost.localdomain systemd[1]: Started ntfy server.
-- Subject: Unit ntfy.service has finished start-up
-- Defined-By: systemd
-- Support: https://access.redhat.com/support
--
-- Unit ntfy.service has finished starting up.
--
-- The start-up result is done.
Jan 04 12:59:41 localhost.localdomain systemd[6584]: ntfy.service: Failed to determine user credentials: No such process
Jan 04 12:59:41 localhost.localdomain systemd[6584]: ntfy.service: Failed at step USER spawning /usr/bin/ntfy: No such process
-- Subject: Process /usr/bin/ntfy could not be executed
-- Defined-By: systemd
-- Support: https://access.redhat.com/support
--
-- The process /usr/bin/ntfy could not be executed and failed.
--
-- The error number returned by this process is 3.
Jan 04 12:59:41 localhost.localdomain systemd[1]: ntfy.service: Main process exited, code=exited, status=217/USER
Jan 04 12:59:41 localhost.localdomain systemd[1]: ntfy.service: Failed with result 'exit-code'.

Manually creating this user/group solves the problem for now

[binwiederhier]

It was a late addition to add the user. If you can provide a PR to fix it that would help. If not I'll get to it eventually. My apologies.

[cmeis]

Hm, just had a look at the postinst.sh / postrm.sh and they both seem to contain the necessary code the create/delete the user.
The problem will be that I'm testing on a RedHat flavour system, where the parameters to the postinst.sh/postrm.sh seem to be different.
Where $1 is "configure" or "purge" on Debian (which is in your code), RedHat-flavoured systems will use a "1" for upgrade (and install?) and a "0" for removal.
I'll try to whip up some dev VM to be able to build the rpm and test myself...

[binwiederhier]

That's what I figured. It would be super awesome if you could fix those. If not, I'll probably figure something out, but it won't be today. :-)

[cmeis]

I spent some hours yesterday trying to build ntfy locally.
No joy in RHEL world (missing cross compilers).
Installed an Ubuntu 20.04 workstation with development tools, but only ALMOST managed to get a build running through correctly.

Not sure where I'm going wrong, but will probably only find time to continue this next week...

[binwiederhier]

I am very sorry you had such a hard time. The static linking and cross compiling and the docs issue make it annoying and hard.

I need to make that easier, and also make it build in a GitHub action.

[cmeis]

Just created a pull request. No regular GitHub user here, so please bear with me ;-)
As I wasn't able to build the RPM locally, I used the rpmrebuild tool to modify the scriptlets in the official 1.11.2 rpm for local testing. In my testing users are created/removed correctly now on RHEL-flavoured Linux (tested on CentOS 8 and AlmaLinux 8).

[binwiederhier]

Awesome, and the pull request looks great. I let some comments for you.