Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn the user in the barplot legends about tips that have no feature metadata / are not in the BIOM table #362

Open
fedarko opened this issue Aug 29, 2020 · 0 comments

Comments

@fedarko
Copy link
Collaborator

fedarko commented Aug 29, 2020

A warning is shown for continuous barplot legends when some tips have non-numeric feature metadata for the field:

image

(this is with a test version of the MP dataset where I replaced a few tips' Confidence values with non-numeric junk.)

It would be good to also show a warning about tips that do not contain any feature metadata (for which no bars are drawn in a feature metadata barplot, at least assuming that some color / length encoding is used), as well as about tips that are not present in the BIOM table (for which no bars are drawn in a sample metadata barplot, since we can't associate the tip with any samples). For 16S datasets, both of these cases will probably only happen when --p-no-filter-unobserved-features-from-phylogeny is used.

The main challenge in making the code for this work will probably just be passing the information of "there were tips without [feature|sample] metadata" to the barplot layer objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant