You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One of the reasons that the bug in #495 slipped through, I think, is that the CI runs all of its tests within a QIIME 2 conda environment -- so if there are installation errors made due to installing Empress into an environment that doesn't have all the QIIME 2 stuff pre-loaded, these errors won't be caught on the CI.
As a quick solution, one way to fix this would be adding a chunk of code (a build? a step? I'm not sure yet...) to the GitHub actions script that creates a new "vanilla" conda environment with just Python installed, and then tests that following the installation instructions in the README (see #495 -- need to install Cython/NumPy first) installs Empress properly. To test this environment, we could just run the couple of standalone-specific tests Empress has set up -- nosetest has ways of only running a handful of tests.
This would be really useful to have in -- since changes within the Python ecosystem at large can be more volatile than those within a QIIME 2 environment, this sort of setup would help keep us safe from Weird Stuff Happening (tm).
The text was updated successfully, but these errors were encountered:
Currently in tests/python/test_cli.py we're set up to load the qza files through the Artifact API and convert them using transformers. What do we think about changing this to just unzip the files into the the Click isolated filesystem (which we are using anyway) and removing the qiime2 import?
EDIT: make-dev-page.py could also probably be modified the same way.
One of the reasons that the bug in #495 slipped through, I think, is that the CI runs all of its tests within a QIIME 2 conda environment -- so if there are installation errors made due to installing Empress into an environment that doesn't have all the QIIME 2 stuff pre-loaded, these errors won't be caught on the CI.
As a quick solution, one way to fix this would be adding a chunk of code (a build? a step? I'm not sure yet...) to the GitHub actions script that creates a new "vanilla" conda environment with just Python installed, and then tests that following the installation instructions in the README (see #495 -- need to install Cython/NumPy first) installs Empress properly. To test this environment, we could just run the couple of standalone-specific tests Empress has set up -- nosetest has ways of only running a handful of tests.
This would be really useful to have in -- since changes within the Python ecosystem at large can be more volatile than those within a QIIME 2 environment, this sort of setup would help keep us safe from Weird Stuff Happening (tm).
The text was updated successfully, but these errors were encountered: