Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji assignment failure | Extra nickname in RDF file #92

Open
qin-yu opened this issue Jun 20, 2024 · 6 comments
Open

Emoji assignment failure | Extra nickname in RDF file #92

qin-yu opened this issue Jun 20, 2024 · 6 comments

Comments

@qin-yu
Copy link

qin-yu commented Jun 20, 2024

Hey @oeway, Fynn is on holiday and I see you are the recent contributor so I'm bugging you here. I just tried to upload a model that passed local bioimageio.core.test_model. But there are three problems:

  1. The emoji doesn't show for it's name philosophical-panda.

    image

  2. While the CIs stage philosophical-panda #207 and test philosophical-panda draft #238 passes with green ticks, uploader shows nothing passed.

    image

  3. I think test philosophical-panda draft #238 skipped important tests.

@oeway
Copy link
Contributor

oeway commented Jun 24, 2024

Thanks for the report!

It looks like we have some bugs in the CI, it didn't report the right status to the uploader, since the uploader only displays a json file generated by the CI.

Will need @FynnBe to take a look.

@qin-yu
Copy link
Author

qin-yu commented Jul 2, 2024

Hi @oeway, for uploader-assigning-no-emoji error, I still have no clue; but for the CI failure, it was because the uploader tried to add nickname: xxx to RDF which is now redundant and should be removed (according to Fynn), and I guess this can only be solved from this repo. He just came back from holiday and is re-running my upload after manually removing the extra nickname line in RDF (so I don't @ him here).

@qin-yu qin-yu changed the title Some problems during upload Emoji assignment failure | Extra nickname in RDF file Jul 2, 2024
@qin-yu
Copy link
Author

qin-yu commented Jul 2, 2024

Since we now know the cause of these issues, I changed the name here. Please note I have another comment above if you are viewing from mobile or using a webpage that doesn't update itself.

@oeway
Copy link
Contributor

oeway commented Jul 10, 2024

Hi @qin-yu thanks for looking into this, I have fixed it here: 0fbf875

@qin-yu
Copy link
Author

qin-yu commented Jul 11, 2024

Thanks @oeway! There is another problem, specifically for my philosophical-panda, I tried to upload rdf.yaml with or without id_emoji: 🐼, my model gets undefined emoji in all cases.

@qin-yu
Copy link
Author

qin-yu commented Jul 11, 2024

The last time I tried was after your fix

0fbf875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants