Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why pad a 0 in front? #2

Open
bhomass opened this issue Jun 5, 2021 · 0 comments
Open

why pad a 0 in front? #2

bhomass opened this issue Jun 5, 2021 · 0 comments

Comments

@bhomass
Copy link

bhomass commented Jun 5, 2021

you allow 150 max atoms per molecule, but in the code for bond encoding, you used +1 to make the dimension 151. Then throughout the model architecture, you keep having to pad the beginning to convert 150 to 151. I having found any good reason for that. Seems 150 would have worked just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant