Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 lint/noRedeclare should allow type param and function param with the same name #1992

Closed
1 task done
Conaclos opened this issue Mar 7, 2024 · 0 comments · Fixed by #2047
Closed
1 task done

🐛 lint/noRedeclare should allow type param and function param with the same name #1992

Conaclos opened this issue Mar 7, 2024 · 0 comments · Fixed by #2047
Assignees
@Conaclos
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@Conaclos
Copy link
Member

Conaclos commented Mar 7, 2024

Environment information

Playground

What happened?

Using the same name for a function parameter and a type parameter triggers lint/noRedeclare.
Playground.

Expected result

Because a type parameter is a type and a function parameter is a variable, both should coexist. This should not be reported as a redeclaration.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@Conaclos Conaclos added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug labels Mar 7, 2024
@Conaclos Conaclos self-assigned this Mar 7, 2024
@Conaclos Conaclos mentioned this issue Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Conaclos Conaclos

Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lint/noRedeclare): don't report type param and param with same name biomejs/biome
1 participant
@Conaclos